Re: samba does not work with liburing 2.3

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

+ Adding Caleb Sander <csander@purestorage.com> to the CC list.

On 11/8/22 8:26 PM, Stefan Metzmacher wrote:
> Am 08.11.22 um 13:56 schrieb Michael Tokarev via samba-technical:
>> 08.11.2022 13:25, Michael Tokarev via samba-technical wrote:
>>> FWIW, samba built against the relatively new liburing-2.3 does not
>>> work right, io_uring-enabled samba just times out in various i/o
>>> operations (eg from smbclient) when liburing used at compile time
>>> was 2.3. It works fine with liburing 2.2.
>>
>> This turned out to be debian packaging issue, but it might affect
>> others too. liburing 2.3 breaks ABI by changing layout of the main
>> struct io_uring object in a significant way.
>>
>> http://bugs.debian.org/1023654
> 
> I don't see where this changes the struct size:
> 
> -       unsigned pad[4];
> +       unsigned ring_mask;
> +       unsigned ring_entries;
> +
> +       unsigned pad[2];
> 
> But I see a problem when you compile against 2.3 and run against 2.2
> as the new values are not filled.
> 
> The problem is the mixture of inline and non-inline functions...
> 
> The packaging should make sure it requires the version is build against...

-- 
Ammar Faizi