From: Jens Axboe <[email protected]>
To: Jia-Ju Bai <[email protected]>, [email protected]
Cc: [email protected], [email protected],
TOTE Robot <[email protected]>
Subject: Re: [PATCH] io_uring: Add NULL checks for current->io_uring
Date: Wed, 11 Jan 2023 07:49:30 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 1/11/23 3:19 AM, Jia-Ju Bai wrote:
> As described in a previous commit 998b30c3948e, current->io_uring could
> be NULL, and thus a NULL check is required for this variable.
>
> In the same way, other functions that access current->io_uring also
> require NULL checks of this variable.
This seems odd. Have you actually seen traces of this, or is it just
based on "guess it can be NULL sometimes, check it in all spots"?
--
Jens Axboe
next prev parent reply other threads:[~2023-01-11 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 10:19 [PATCH] io_uring: Add NULL checks for current->io_uring Jia-Ju Bai
2023-01-11 14:49 ` Jens Axboe [this message]
2023-01-12 2:10 ` Jia-Ju Bai
2023-01-12 2:37 ` Jens Axboe
2023-01-11 14:49 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox