From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DE8C4338F for ; Fri, 23 Jul 2021 17:56:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C71B60F12 for ; Fri, 23 Jul 2021 17:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229459AbhGWRQA (ORCPT ); Fri, 23 Jul 2021 13:16:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbhGWRP6 (ORCPT ); Fri, 23 Jul 2021 13:15:58 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9759C061575 for ; Fri, 23 Jul 2021 10:56:30 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id l18so3487697ioh.11 for ; Fri, 23 Jul 2021 10:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=34Pe8bE5xOlRF7EDsbVPuwXSX7BdV/HHwwshey5X0LI=; b=dipRY5xyLdP1f8LknS9Od4DmvOwbQa07ypsTB9w65eaCSLiCnYa+haJ2mog+hfH3GA FseGzkUW3BUmqVu+2Rc8IBueaQgpTTZUHbQcSXD79ig6vy82tPQyFCmXNxtAZPUMXhZY A3C4+yq42KxL6/0PPsScsQ2+wmqe8LKr9yb3CqBliSzbEDjJXGSeww7rK41XbHdJThlI awgAK5fllqbNJ7nSxKPMQG1UZLYWNpokz3f1/90vo7uNrygJP7HJaUBuYYlmVtgxlp3m Cs61fwc2aik/eMbMYZFjo9b0nZ3B8aLsk/aYS1izgS3JNhOcUGJirSNQDNHAAkJBqW35 tSrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=34Pe8bE5xOlRF7EDsbVPuwXSX7BdV/HHwwshey5X0LI=; b=GsBNijRaaTVw7JwHmJclkBvXQoPDemCB7lq1XENgsnSSEXwRkTgLvP2tXD5ii+OBBz p+znQCpl8VGk2n6V/KYc9cmToZQjp9YTHyeiW+nieKJ3qd2itq5+FFUqIoltkEEGYUts UWIb2DDR+OZv1TZfMyP6dDdWayrS4nygJxUT41vUd/bZ7Rq6hkW07+DUeEOi7pswMSXH ZuLG88iWGH86rQpJn53i2sFkMTtNuwtpBipq6k8ACq3l1gyKYSYHob9rowwesGtMAVce zuZWSGrosKbnwTHsDy7c4C9Z+YDc6AmLtVGfo1IFLvUilRghWCgsi8f+0stNmsdLk39Y GOoA== X-Gm-Message-State: AOAM530BePxX8k1RxUBd0Ief5/G0N7ZpALEQTPiQnVXgw5HLyRKu8WWK OIXxCerPooWcBgJW0Z0DpgOXZA== X-Google-Smtp-Source: ABdhPJyZy16aCwI60W9wTLWaKjkJKsgJKGBbmJE8eTV6oTc0hCA5+KuW9Mfvl1ISD2b/2cLZsqgKAg== X-Received: by 2002:a05:6602:2099:: with SMTP id a25mr4829293ioa.143.1627062990069; Fri, 23 Jul 2021 10:56:30 -0700 (PDT) Received: from [192.168.1.10] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id k21sm18819166ios.0.2021.07.23.10.56.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 10:56:29 -0700 (PDT) Subject: Re: [PATCH 3/3] io_uring: refactor io_sq_offload_create() From: Jens Axboe To: Al Viro Cc: Pavel Begunkov , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linus Torvalds References: <939776f90de8d2cdd0414e1baa29c8ec0926b561.1618916549.git.asml.silence@gmail.com> <57758edf-d064-d37e-e544-e0c72299823d@kernel.dk> <8fb39022-ba21-2c1f-3df5-29be002014d8@kernel.dk> <591b4a1e-606a-898c-7470-b5a1be621047@kernel.dk> Message-ID: <640bdb4e-f4d9-a5b8-5b7f-5265b39c8044@kernel.dk> Date: Fri, 23 Jul 2021 11:56:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <591b4a1e-606a-898c-7470-b5a1be621047@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 7/23/21 11:36 AM, Jens Axboe wrote: > On 7/23/21 11:32 AM, Jens Axboe wrote: >> Outside of that, we're not submitting off release, only killing anything >> pending. The only odd case there is iopoll, but that doesn't resubmit >> here. > > OK perhaps I'm wrong on this one - if we have a pending iopoll request, > and we run into the rare case of needing resubmit, we are doing that off > the release path and that should not happen. Hence it could potentially > happen for iosched and/or low queue depth devices, if you are using a > ring for pure polling. I'll patch that up. Will send out two patches for this. Note that I don't see this being a real issue, as we explicitly gave the ring fd to another task, and being that this is purely for read/write, it would result in -EFAULT anyway. -- Jens Axboe