From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07A0BC2D0DB for ; Fri, 31 Jan 2020 22:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC07520707 for ; Fri, 31 Jan 2020 22:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="he0YCpvP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726202AbgAaWYI (ORCPT ); Fri, 31 Jan 2020 17:24:08 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40362 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgAaWYI (ORCPT ); Fri, 31 Jan 2020 17:24:08 -0500 Received: by mail-pf1-f194.google.com with SMTP id q8so4070696pfh.7 for ; Fri, 31 Jan 2020 14:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=oNPDXr5T2F3ltBr6ZWUFkUTRD5GIjwn23cg1EDJm7Qc=; b=he0YCpvPIXitkS2gkBPL7SoeIrDKJ6TyukF76x/Odh2lowB7nunGusPhq/d4ccAJKo w9snSRWXHEqoPw0uC4UfmOa/YxRkzBM4y0IncMjvWnm8BTlSvbpz0kIOJTF5NBwvzt1I GFarbrT5hGOVCKGgTj+B64Zxc3ObuJR5Wxvlf4nXLAuH/stizMkhu9XxTr0NMywPpGXa FgMjJjW0oai/+kJeUc99yV5YVuA3PGQX61Hj3YLkNCkqfzheOYSA052mK5tcZsh9iHQR n+wzROfVBw1/+JU/QpCXDwSiqH3LfEKAIZrcEkTP3flw7WJ6c6HCJRYTIlO/htosbNVJ jnuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oNPDXr5T2F3ltBr6ZWUFkUTRD5GIjwn23cg1EDJm7Qc=; b=cIb/NxyeoD1kOnuiIthYE83Yz3z00F1ckbv5lEMIt59AZdQ4A9SdzA0OgO3R+KyJOJ 9B8Yz24uM5UyAC0ktH7tO8LMh06JBNLjRFzEYk4V+JUseVpJD/bYByQT9Iig6+E6nCDM rfupX5lbYPRUddXYie51g4eyUpGMt1MKLMI6Pe1Xi2Y0Zc/kdvZ7LITboWZLLx7wtNDL XVL0L5jhcDPu8u6wa46jxZCpxHMfxdgpLqI8ZVXWP9gpoQiUT1nRjsjvI1WoOw6Bx1V4 cBlbAIe6TkObJEauzOgwr6THXVvl8LjAY+lD+Buvtv+sMiQYg+N2Xmlf1t6/nn9o0Aee VQ6g== X-Gm-Message-State: APjAAAU/8UGWBdOvdeLlkMbd0G2/eAUftsXjCubNVNwMkppFAwdeq6fH fJAdVR7rZEA8d5ALYM5zNts0FQ== X-Google-Smtp-Source: APXvYqzqKO/A1Xn8xjFjOlUoV7dczVeMJ+fz7E71+uwn7PFxZK4KZm22X7LcGl3v3xEtRmZxo51WHA== X-Received: by 2002:a63:2309:: with SMTP id j9mr2382056pgj.54.1580509447440; Fri, 31 Jan 2020 14:24:07 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id j7sm966255pji.7.2020.01.31.14.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2020 14:24:06 -0800 (PST) Subject: Re: [PATCH 1/1] io_uring: remove extra ->file check To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <649d912f-704b-d362-2bc7-1217840de672@kernel.dk> Date: Fri, 31 Jan 2020 15:24:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/31/20 3:22 PM, Pavel Begunkov wrote: > It won't ever get into io_prep_rw() when req->file haven't been set in > io_req_set_file(), hence remove the check. Applied for 5.6, thanks. -- Jens Axboe