From: Jens Axboe <[email protected]>
To: Stefan Roesch <[email protected]>,
[email protected], [email protected]
Cc: [email protected],
Olivier Langlois <[email protected]>,
Jakub Kicinski <[email protected]>
Subject: Re: [PATCH v10 2/5] io-uring: add napi busy poll support
Date: Wed, 26 Apr 2023 19:46:22 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/26/23 7:41?PM, Jens Axboe wrote:
I'd probably also do this:
diff --git a/io_uring/napi.c b/io_uring/napi.c
index ca12ff5f5611..35a29fd9afbc 100644
--- a/io_uring/napi.c
+++ b/io_uring/napi.c
@@ -95,12 +95,17 @@ static bool io_napi_busy_loop_should_end(void *p, unsigned long start_time)
{
struct io_wait_queue *iowq = p;
- return signal_pending(current) ||
- io_should_wake(iowq) ||
- io_napi_busy_loop_timeout(start_time, iowq->napi_busy_poll_to);
+ if (signal_pending(current))
+ return true;
+ if (io_should_wake(iowq))
+ return true;
+ if (io_napi_busy_loop_timeout(start_time, iowq->napi_busy_poll_to))
+ return true;
+ return false;
}
as that is easier to read.
--
Jens Axboe
next prev parent reply other threads:[~2023-04-27 1:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 18:18 [PATCH v10 0/5] io_uring: add napi busy polling support Stefan Roesch
2023-04-25 18:18 ` [PATCH v10 1/5] io-uring: move io_wait_queue definition to header file Stefan Roesch
2023-04-25 18:18 ` [PATCH v10 2/5] io-uring: add napi busy poll support Stefan Roesch
2023-04-27 1:41 ` Jens Axboe
2023-04-27 1:46 ` Jens Axboe [this message]
2023-04-27 17:34 ` Stefan Roesch
2023-04-27 1:50 ` Jens Axboe
2023-04-27 1:59 ` Jens Axboe
2023-04-27 18:21 ` Stefan Roesch
2023-04-27 17:44 ` Stefan Roesch
2023-04-27 16:27 ` Stefan Roesch
2023-04-28 1:09 ` Jens Axboe
2023-04-27 2:56 ` Ammar Faizi
2023-04-27 11:16 ` Jens Axboe
2023-04-25 18:18 ` [PATCH v10 3/5] io-uring: add sqpoll support for napi busy poll Stefan Roesch
2023-04-25 18:18 ` [PATCH v10 4/5] io_uring: add register/unregister napi function Stefan Roesch
2023-04-25 18:18 ` [PATCH v10 5/5] io_uring: add prefer busy poll to register and unregister napi api Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox