public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Kanchan Joshi <joshi.k@samsung.com>
To: Anuj Gupta <anuj20.g@samsung.com>, axboe@kernel.dk, kbusch@kernel.org
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring/rw: handle IORING_OP_URING_CMD128 in iopoll dispatch
Date: Thu, 19 Feb 2026 19:02:54 +0530	[thread overview]
Message-ID: <64ad9aa3-68be-4c82-97dc-317c350e0d6d@samsung.com> (raw)
In-Reply-To: <20260219123136.155590-1-anuj20.g@samsung.com>

On 2/19/2026 6:01 PM, Anuj Gupta wrote:
> io_uring_classic_poll() special-cases only IORING_OP_URING_CMD for
> uring-cmd iopoll dispatch. IORING_OP_URING_CMD128 falls into the generic
> rw branch, which calls file->f_op->iopoll() after casting to struct io_rw.
> 
> That is the wrong callback path for uring_cmd requests, which should go
> through ->uring_cmd_iopoll(). Treat IORING_OP_URING_CMD128 the same as
> IORING_OP_URING_CMD in io_uring_classic_poll().
> 
> Fixes: 1cba30bf9fdd ("io_uring: add support for IORING_SETUP_SQE_MIXED")

Just noticed that Caleb had sent a patch that handles this more completely:

https://lore.kernel.org/io-uring/20260219013534.4140776-1-csander@purestorage.com/

      reply	other threads:[~2026-02-19 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260219123601epcas5p3102acea27f92bc92a8e482c18e74103f@epcas5p3.samsung.com>
2026-02-19 12:31 ` [PATCH] io_uring/rw: handle IORING_OP_URING_CMD128 in iopoll dispatch Anuj Gupta
2026-02-19 13:32   ` Kanchan Joshi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64ad9aa3-68be-4c82-97dc-317c350e0d6d@samsung.com \
    --to=joshi.k@samsung.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=kbusch@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox