From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
io-uring@vger.kernel.org,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 1/5] net: timestamp: add helper returning skb's tx tstamp
Date: Wed, 04 Jun 2025 09:38:23 -0400 [thread overview]
Message-ID: <68404c4fa8590_1e99f529486@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <abd16c0d-480e-4bc7-a4ce-6775e6068e70@gmail.com>
Pavel Begunkov wrote:
> On 6/2/25 14:31, Willem de Bruijn wrote:
> > Pavel Begunkov wrote:
> >> On 6/1/25 14:52, Willem de Bruijn wrote:
> >>> Pavel Begunkov wrote:
> >>>> Add a helper function skb_get_tx_timestamp() that returns a tx timestamp
> >>>> associated with an skb from an queue queue.
> ...>> ...>> diff --git a/net/socket.c b/net/socket.c
> >>>> index 9a0e720f0859..d1dc8ab28e46 100644
> >>>> --- a/net/socket.c
> >>>> +++ b/net/socket.c
> >>>> @@ -843,6 +843,55 @@ static void put_ts_pktinfo(struct msghdr *msg, struct sk_buff *skb,
> >>>> sizeof(ts_pktinfo), &ts_pktinfo);
> >>>> }
> >>>>
> >>>> +bool skb_has_tx_timestamp(struct sk_buff *skb, struct sock *sk)
> >>>
> >>> Here and elsewhere: consider const pointers where possible
> >>
> >> will do
>
> I constantized the sock pointer in v2 but can't do same with skb as
> skb_hwtstamps() and other helpers don't work with const. I can follow
> up on top preparing those helpers, but to avoid cross tree conflicts
> it's probably better to leave the helpers from this patch without
> const untill all is merged and pulled, hope that's works for you.
Ok. No need to follow up per se.
next prev parent reply other threads:[~2025-06-04 13:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 12:18 [PATCH io_uring-next 0/5] io_uring cmd for tx timestamps Pavel Begunkov
2025-05-30 12:18 ` [PATCH 1/5] net: timestamp: add helper returning skb's tx tstamp Pavel Begunkov
2025-05-30 18:14 ` Stanislav Fomichev
2025-05-30 18:30 ` Stanislav Fomichev
2025-05-30 18:44 ` Pavel Begunkov
2025-06-01 13:52 ` Willem de Bruijn
2025-06-02 9:57 ` Pavel Begunkov
2025-06-02 13:31 ` Willem de Bruijn
2025-06-04 8:51 ` Pavel Begunkov
2025-06-04 13:38 ` Willem de Bruijn [this message]
2025-05-30 12:18 ` [PATCH 2/5] io_uring/poll: introduce io_arm_apoll() Pavel Begunkov
2025-05-31 10:28 ` Pavel Begunkov
2025-05-30 12:18 ` [PATCH 3/5] io_uring/cmd: allow multishot polled commands Pavel Begunkov
2025-05-30 12:18 ` [PATCH 4/5] io_uring: add mshot helper for posting CQE32 Pavel Begunkov
2025-05-30 12:18 ` [PATCH 5/5] io_uring/netcmd: add tx timestamping cmd support Pavel Begunkov
2025-05-31 8:34 ` kernel test robot
2025-05-30 13:30 ` [PATCH io_uring-next 0/5] io_uring cmd for tx timestamps Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68404c4fa8590_1e99f529486@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=io-uring@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox