From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: asml.silence@gmail.com, netdev@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Jason Xing <kerneljasonxing@gmail.com>
Subject: Re: [PATCH v4 5/5] io_uring/netcmd: add tx timestamping cmd support
Date: Sun, 15 Jun 2025 22:33:05 -0400 [thread overview]
Message-ID: <684f8261d288f_1e2690294b1@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <a0e726f33e940429276a209532b36090d3976fa5.1749839083.git.asml.silence@gmail.com>
Pavel Begunkov wrote:
> Add a new socket command which returns tx time stamps to the user. It
> provide an alternative to the existing error queue recvmsg interface.
> The command works in a polled multishot mode, which means io_uring will
> poll the socket and keep posting timestamps until the request is
> cancelled or fails in any other way (e.g. with no space in the CQ). It
> reuses the net infra and grabs timestamps from the socket's error queue.
>
> The command requires IORING_SETUP_CQE32. All non-final CQEs (marked with
> IORING_CQE_F_MORE) have cqe->res set to the tskey, and the upper 16 bits
> of cqe->flags keep tstype (i.e. offset by IORING_CQE_BUFFER_SHIFT). The
> timevalue is store in the upper part of the extended CQE. The final
> completion won't have IORING_CQE_F_MORE and will have cqe->res storing
> 0/error.
>
> Suggested-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
prev parent reply other threads:[~2025-06-16 2:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 18:32 [PATCH v4 0/5] io_uring cmd for tx timestamps Pavel Begunkov
2025-06-13 18:32 ` [PATCH v4 1/5] net: timestamp: add helper returning skb's tx tstamp Pavel Begunkov
2025-06-16 2:31 ` Willem de Bruijn
2025-06-16 9:44 ` Pavel Begunkov
2025-06-16 14:58 ` Willem de Bruijn
2025-06-16 16:44 ` Pavel Begunkov
2025-06-13 18:32 ` [PATCH v4 2/5] io_uring/poll: introduce io_arm_apoll() Pavel Begunkov
2025-06-13 18:32 ` [PATCH v4 3/5] io_uring/cmd: allow multishot polled commands Pavel Begunkov
2025-06-13 18:32 ` [PATCH v4 4/5] io_uring: add mshot helper for posting CQE32 Pavel Begunkov
2025-06-13 18:32 ` [PATCH v4 5/5] io_uring/netcmd: add tx timestamping cmd support Pavel Begunkov
2025-06-16 2:33 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=684f8261d288f_1e2690294b1@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=io-uring@vger.kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox