From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A0A914E2C9 for ; Wed, 19 Jun 2024 13:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718804447; cv=none; b=fawGGU17nXy9w2gL6UDI15nabp32lx/j2Tvh5X0iBHWyiHydH9eGKGp/IqXnwgPYtnfqx2jd3S8Nmdu5BAGLZ4vKpUTs3mqQ4wK4oDQgr8MUpg/611clbp1uOGTJnZyz5D/0XYBDag7hPweRQn7woe55+6bYHH7wQqUuvdJCXug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718804447; c=relaxed/simple; bh=sG2Lpy3VpXT3f6OxbZel147PXaMOuouxB+lV8yBKBV4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rRpvJO7+Cv2ybKO9xtOlmjXoSD1otAHneCyf3+ps4oIP4qxbvBD/Cdb2gTzaSdwPhSLQT6fFnKlj6mDDw2qvzm6Q+8sw02fuYEYD7C3W7hyXuo8qQYggUvq+/lZXtvtcq4Iw5rc1RAofHQ/D2SN9ge6HHfbcfJV+cVg9ftEWwRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=E7cuZqR7; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="E7cuZqR7" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7063478ff2eso22890b3a.0 for ; Wed, 19 Jun 2024 06:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1718804442; x=1719409242; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZI5BSix8LmWzY7VDgC5VyaiYfKDgyRvZmlaJ7+6sKGo=; b=E7cuZqR75rKoEE52RGCPTuq72Ql9RTNiLbEuTwqK+su7VAWro600pxIhPI5sHZlMeI Gvmlr6NJ0eQFzId+lJDXoa+aQ4shv3qNgpuG3kLCbDwDdJyWPawBLQcETvSauheCehRN mDLbYo4r6ZDtfZHlZNqHe5Rkm7N0ZYuabUAsmmbr39jG62esfYCSyB0uNcBR3QlIqTKv HUMhS0lOFHXLcBGYRQZMs/IjBCrp07mcqirHVL+/KIGEBRDi3QOpFR+M0Y5zCJiT8q2T tpLXRcn+22FS1EIpjOo4/j0wjDyfeZUhC/Vjj4yTvXqTvcgeHsfIJ2xI9bfukJ7qmPvn guBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718804442; x=1719409242; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZI5BSix8LmWzY7VDgC5VyaiYfKDgyRvZmlaJ7+6sKGo=; b=lt4wNBgr7AXoxzmghMg0BVCMFY2O4KscseELGA5xg3IK0GRtUFiQXJWpyNYF6Wi7PK 7Pk/mlRbK44NwX2GMbO6RA7iwz1nSb/NFyLiyH2trfh2XQcK/uxvKepdkc3ZVHnfvvnK guAZzVO/qf1TWacKnW0o1FjqE9Zp3y+69MTyEjKg2IVsL8icQZKXcYLgQRaK0BxohYNS UvHIHdft7j4xMYCt1VmhWESf+M9azdwm+DcaB75tPB3b+dsspyf4yHqSrYJmMyd+Vflk QajX41j87BFe/PpHVNVaEpW4A9pDim+J55iizYBvPDbfCNaLrHLM+D21E7V/xZx8NHia 8FtQ== X-Gm-Message-State: AOJu0YxfxGpBYFAK0CxhCShnkuR29aOrQqoDoeFpOXrLhY5PadtzI3OM 7xMbOgmwgLRfI4JFMOf2YMvmXzaIrMsQl8B3txa6TvMSKC9INe1c/kfS0Uo3DqLNiRH7sHaYvQu W X-Google-Smtp-Source: AGHT+IHicUj38k3OCiW5PJksXObOTIRP9R4I5CfXJOeyErwyGssRFHOWu7QNQ6LRgHLsmIKJ6wqTtQ== X-Received: by 2002:a05:6a20:729b:b0:1bc:bade:ea3 with SMTP id adf61e73a8af0-1bcbb732001mr2841430637.5.1718804442532; Wed, 19 Jun 2024 06:40:42 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c4c45ab7fasm12909516a91.2.2024.06.19.06.40.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 06:40:42 -0700 (PDT) Message-ID: <68b482cd-4516-4e00-b540-4f9ee492d6e3@kernel.dk> Date: Wed, 19 Jun 2024 07:40:40 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] net: Split a __sys_bind helper for io_uring To: Jakub Kicinski , Gabriel Krisman Bertazi Cc: io-uring@vger.kernel.org, netdev@vger.kernel.org References: <20240614163047.31581-1-krisman@suse.de> <20240618174953.5efda404@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <20240618174953.5efda404@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/18/24 6:49 PM, Jakub Kicinski wrote: > On Fri, 14 Jun 2024 12:30:44 -0400 Gabriel Krisman Bertazi wrote: >> io_uring holds a reference to the file and maintains a >> sockaddr_storage address. Similarly to what was done to >> __sys_connect_file, split an internal helper for __sys_bind in >> preparation to supporting an io_uring bind command. >> >> Reviewed-by: Jens Axboe >> Signed-off-by: Gabriel Krisman Bertazi > > Acked-by: Jakub Kicinski Are you fine with me queueing up 1-2 via the io_uring branch? I'm guessing the risk of conflict should be very low, so doesn't warrant a shared branch. -- Jens Axboe