From: Jens Axboe <[email protected]>
To: Dylan Yudaken <[email protected]>,
[email protected], [email protected]
Subject: Re: [PATCH 5.19] io_uring: move io_uring_get_opcode out of TP_printk
Date: Thu, 23 Jun 2022 08:36:02 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 6/23/22 2:37 AM, Dylan Yudaken wrote:
> @@ -390,6 +402,8 @@ TRACE_EVENT(io_uring_submit_sqe,
> __field( u32, flags )
> __field( bool, force_nonblock )
> __field( bool, sq_thread )
> +
> + __string( op_str, io_uring_get_opcode(opcode) )
> ),
>
> TP_fast_assign(
> @@ -399,12 +413,13 @@ TRACE_EVENT(io_uring_submit_sqe,
> __entry->opcode = opcode;
> __entry->flags = flags;
> __entry->force_nonblock = force_nonblock;
> - __entry->sq_thread = sq_thread;
> +
> + __assign_str(op_str, io_uring_get_opcode(opcode));
> ),
>
Looks like a spurious removal here of the sq_thread assignment? I will
fix it up.
--
Jens Axboe
next prev parent reply other threads:[~2022-06-23 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 8:37 [PATCH 5.19] io_uring: move io_uring_get_opcode out of TP_printk Dylan Yudaken
2022-06-23 14:36 ` Jens Axboe [this message]
2022-06-23 14:59 ` Dylan Yudaken
2022-06-25 12:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox