From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA415C433FE for ; Tue, 11 Oct 2022 02:02:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229492AbiJKCCA (ORCPT ); Mon, 10 Oct 2022 22:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiJKCBz (ORCPT ); Mon, 10 Oct 2022 22:01:55 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4108A7549E for ; Mon, 10 Oct 2022 19:01:54 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id i7-20020a17090a65c700b0020ad9666a86so14644164pjs.0 for ; Mon, 10 Oct 2022 19:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yAEc/49pN/A7I28fNr7F4lPftvaseeDWjDyBYsFrup8=; b=lqqwD+aH/xkj5QMB6t2Cs/AXNtlbOk6vgWkm6IneVxa/cvWBnDEJsDZEEpKKquLT34 RfaMRX6WrtgCD79qsljDP+h/ZODNd3svnrk4AC4DBIMlB/qhMh1gr+u/NPUJnN3adleo uyxUYulMsityuuHqowmob/qFA1jpOLQr8bg6l9FVZyJZeAfNzdcgcsqBeHaI9YDLOCzL l8lFII+WWgNt4krXfS32D+M4srkHT793PWjljAmR1vXCwJ0UHmk3U3yaStuXa0DlN4Ys FZn3Pa2b+sJC79xn5WQ3jvkZbTYZov/NDzW1ezxlY2n6PiwRKf3s8soj+O9gKHHCWgzQ OMpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yAEc/49pN/A7I28fNr7F4lPftvaseeDWjDyBYsFrup8=; b=XtKPjRawxwLqTwZlC8srknlz33/wzEAZBe11WITvApU6hPrOK5P+p3LyRTJyfFBx7a cHNZaTUGhwXDdNzKMDgeaKTy4mLNAKTlZlFD9+qclqU7gqlpYYza597WaU3txXHNivvH 1GEC8S633+GUutMfNprgbB+CBfJNt5RnAwrJRXlwV/jtqmIH8w0Th6Tz4QEbw2T1ZZb5 6NnLN465Oo5iRt9QJO0PaLo9+q08A7sRUZHRLKtvhSmqyg5PlfiLcLNtEGDSBdezyLSP sEztzz8db7qhPJ/yMzdCnuPzp+Q61WcNZUcqruB8aJjrjpyN3wW5iffmB7QNHoCNR0VQ 34XQ== X-Gm-Message-State: ACrzQf0bFIAlM+CsNb9zxTfhRUke5UEGz4QgpmuHP/roCSWgMwljEBbe rphCsaLJeVYAlEfK7J97g9aOZw== X-Google-Smtp-Source: AMsMyM54LPT4urYyCBZEkgnyJFbPNheS+qRspWLKKQaKLF6ydB8SVLtTZZvIQTLQH9uYv7AjVB7GOA== X-Received: by 2002:a17:90a:5308:b0:20b:1eae:c94e with SMTP id x8-20020a17090a530800b0020b1eaec94emr25158007pjh.88.1665453713546; Mon, 10 Oct 2022 19:01:53 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d3-20020a63fd03000000b00460d89df1f1sm3996272pgh.57.2022.10.10.19.01.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 19:01:52 -0700 (PDT) Message-ID: <697611c3-04b0-e8ea-d43d-d05b7c334814@kernel.dk> Date: Mon, 10 Oct 2022 20:01:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [regression, v6.0-rc0, io-uring?] filesystem freeze hangs on sb_wait_write() Content-Language: en-US To: Pavel Begunkov , Dave Chinner , viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org References: <20221010050319.GC2703033@dread.disaster.area> <20221011004025.GE2703033@dread.disaster.area> <8e45c8ee-fe38-75a9-04f4-cfa2d54baf88@gmail.com> From: Jens Axboe In-Reply-To: <8e45c8ee-fe38-75a9-04f4-cfa2d54baf88@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 10/10/22 7:10 PM, Pavel Begunkov wrote: > On 10/11/22 01:40, Dave Chinner wrote: > [...] >> I note that there are changes to the the io_uring IO path and write >> IO end accounting in the io_uring stack that was merged, and there >> was no doubt about the success/failure of the reproducer at each >> step. Hence I think the bisect is good, and the problem is someone >> in the io-uring changes. >> >> Jens, over to you. >> >> The reproducer - generic/068 - is 100% reliable here, io_uring is >> being exercised by fsstress in the background whilst the filesystem >> is being frozen and thawed repeatedly. Some path in the io-uring >> code has an unbalanced sb_start_write()/sb_end_write() pair by the >> look of it.... > > A quick guess, it's probably > > b000145e99078 ("io_uring/rw: defer fsnotify calls to task context") > > From a quick look, it removes  kiocb_end_write() -> sb_end_write() > from kiocb_done(), which is a kind of buffered rw completion path. Yeah, I'll take a look. Didn't get the original email, only Pavel's reply? -- Jens Axboe