public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [PATCHSET v2 RFC 0/11] Add support for ring mapped provided buffers
Date: Sun, 1 May 2022 14:14:28 +0100	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 4/29/22 18:56, Jens Axboe wrote:
> Hi,
> 
> This series builds to adding support for a different way of doing
> provided buffers. The interesting bits here are patch 11, which also has
> some performance numbers an an explanation of it.

Jens, would be great if you can CC me for large changes, you know
how it's with mailing lists nowadays...

1) reading "io_uring: abstract out provided buffer list selection"

Let's move io_ring_submit_unlock() to where the lock call is.
In the end, it's only confusing and duplicates unlock in
io_ring_buffer_select() and io_provided_buffer_select().

2) As it's a new API, let's do bucket selection right, I quite
don't like io_buffer_get_list(). We can replace "bgid" with
indexes into an array and let the userspace to handle indexing.
Most likely it knows the index right away or can implement indexes
lookup with as many tricks and caching it needs.


> Patches 1..5 are cleanups that should just applied separately, I
> think the clean up the existing code quite nicely.
> 
> Patch 6 is a generic optimization for the buffer list lookups.
> 
> Patch 7 adds NOP support for provided buffers, just so that we can
> benchmark the last change.
> 
> Patches 8..10 are prep for patch 11.
> 
> Patch 11 finally adds the feature.
> 
> This passes the full liburing suite - obviously this just means that it
> didn't break anything existing (that I know of), the only test case for
> the ring buffers is the nop peak benchmark referenced in patch 11.
> 
> v2:	- Minor optimizations
> 	- Fix 4k PAGE_SIZE assumption
> 	- Style cleanup
> 
> Can also be found in my git repo, for-5.19/io_uring-pbuf branch:
> 
> https://git.kernel.dk/cgit/linux-block/log/?h=for-5.19/io_uring-pbuf
> 
>   fs/io_uring.c                 | 463 +++++++++++++++++++++++++---------
>   include/uapi/linux/io_uring.h |  26 ++
>   2 files changed, 370 insertions(+), 119 deletions(-)
> 

-- 
Pavel Begunkov

  parent reply	other threads:[~2022-05-01 13:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 17:56 [PATCHSET v2 RFC 0/11] Add support for ring mapped provided buffers Jens Axboe
2022-04-29 17:56 ` [PATCH 01/11] io_uring: kill io_recv_buffer_select() wrapper Jens Axboe
2022-04-29 17:56 ` [PATCH 02/11] io_uring: make io_buffer_select() return the user address directly Jens Axboe
2022-04-29 17:56 ` [PATCH 03/11] io_uring: kill io_rw_buffer_select() wrapper Jens Axboe
2022-04-29 17:56 ` [PATCH 04/11] io_uring: ignore ->buf_index if REQ_F_BUFFER_SELECT isn't set Jens Axboe
2022-04-29 17:56 ` [PATCH 05/11] io_uring: always use req->buf_index for the provided buffer group Jens Axboe
2022-04-29 17:56 ` [PATCH 06/11] io_uring: cache last io_buffer_list lookup Jens Axboe
2022-04-29 17:56 ` [PATCH 07/11] io_uring: add buffer selection support to IORING_OP_NOP Jens Axboe
2022-04-29 17:56 ` [PATCH 08/11] io_uring: add io_pin_pages() helper Jens Axboe
2022-04-29 17:56 ` [PATCH 09/11] io_uring: abstract out provided buffer list selection Jens Axboe
2022-04-29 17:56 ` [PATCH 10/11] io_uring: relocate io_buffer_get_list() Jens Axboe
2022-04-29 17:56 ` [PATCH 11/11] io_uring: add support for ring mapped supplied buffers Jens Axboe
2022-05-01 13:14 ` Pavel Begunkov [this message]
2022-05-01 13:28   ` [PATCHSET v2 RFC 0/11] Add support for ring mapped provided buffers Jens Axboe
2022-05-01 13:39     ` Pavel Begunkov
2022-05-01 14:25       ` Jens Axboe
2022-05-01 15:00         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox