From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C41E20F07B; Thu, 23 Jan 2025 13:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737638690; cv=none; b=op0aV9NQNxXo9egx6Ljt0jh3aJMk0PBCPiZZYVrOqyg81YowTz68M0QBbBatK/no13r5PRN0IPMNJXjv6ZNo42djjhZmklL2czI7qhN1l2ltnnuKycCXufrnQZEi8L68DK6x5XE8/za5+E4y0iYIBn9BrBx4zdBf2pKK5hsRq80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737638690; c=relaxed/simple; bh=uHpFUE8IirztlIdUESRCVcC+ji0J+CxSdbMwcMv2k4Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DMPT7iZCV3XCfaoMP6JSLi+fK3IgBDxw0h1EtnnKEpFxVRl4u0ezVy8R5tTxUEnbb8obZFSFyA3N72+X5N1GPU8Pf/lRGXBF5i+HFtG66V/PLoDUvIKkpFo3n4AtWYg/eBXiwhjhTb6ciwp3W/0tSLw6BlrzvduSRiGJnhnW5B4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bsbernd.com; spf=pass smtp.mailfrom=bsbernd.com; dkim=pass (2048-bit key) header.d=bsbernd.com header.i=@bsbernd.com header.b=Hr4c5Ny+; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=nolWJ9j5; arc=none smtp.client-ip=103.168.172.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bsbernd.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bsbernd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bsbernd.com header.i=@bsbernd.com header.b="Hr4c5Ny+"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="nolWJ9j5" Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 7911E1380193; Thu, 23 Jan 2025 08:24:47 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Thu, 23 Jan 2025 08:24:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsbernd.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1737638687; x=1737725087; bh=DgQm8nSx1FyUSjMxNSHlnTh4J3z9CNv03MlJfWOOlLk=; b= Hr4c5Ny+nyfTmgatXpR6BLsmy6ziqbw5mX69lYaac2bOHzC/uhkfG+objgWLdyCn wKVwrInNXDsqRzQ45mFTOK07Kgoyb8PLpDOgd+XBWF5C/MtCUGFTY2zc/fQ6Hyxf jLyDImUNmdusaf+t/fsttyTo3CppYKSfJgywKUIYQhimQS71HRNLZFLD0Uj4Y22+ ipxB8R1HJNUFSl0/ewt0uqp9auI80qobi38iZ7XKp4pzT5LOKaR+S4gibO5t17/g feng3vnoOeBcXUJHIvnDxmK3fs9NSWNgo5O0rmy7iCLyFprNYV0POvFGpISuSyZt V1RPATXMggNud1YyJlSFpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1737638687; x= 1737725087; bh=DgQm8nSx1FyUSjMxNSHlnTh4J3z9CNv03MlJfWOOlLk=; b=n olWJ9j5zbKas5auNLW1Cja8pXhD9YIR0Xd1SX+iZCZg+rUjxDyKSNbuRE/RvfWpa mZwo8G2USti+QTiF5akQYwaHIiAJ0kahPYNHBDBxys2ZaGLksHY4rCvYl5eBA7NF BB6QKRDYWliNhm7j7gB8GI19mykvKSU6zfKDPzd3KzAwPd85UeygO1l9XH95NnBE afRdrSLSQKCZdI0rKcK40YoCJDCVtpEV91Z9YZ0ve/FVTG6IxNEZ4mGKvc2PlkCd DpG7yp/5AFK9QljktL54DslFSFynGNZA43t5uEaAdHgDbfZds/0jf6T/ciO8hdWv PB0SfI6dVlzBCdZHTwu4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudejgedgudejjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddv jeenucfhrhhomhepuegvrhhnugcuufgthhhusggvrhhtuceosggvrhhnugessghssggvrh hnugdrtghomheqnecuggftrfgrthhtvghrnhephefhjeeujeelhedtheetfedvgfdtleff uedujefhheegudefvdfhheeuveduueegnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepsggvrhhnugessghssggvrhhnugdrtghomhdpnhgspghr tghpthhtohepuddvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehluhhishesih hgrghlihgrrdgtohhmpdhrtghpthhtohepsghstghhuhgsvghrthesuggunhdrtghomhdp rhgtphhtthhopehmihhklhhoshesshiivghrvgguihdrhhhupdhrtghpthhtoheprgigsg hovgeskhgvrhhnvghlrdgukhdprhgtphhtthhopegrshhmlhdrshhilhgvnhgtvgesghhm rghilhdrtghomhdprhgtphhtthhopehlihhnuhigqdhfshguvghvvghlsehvghgvrhdrkh gvrhhnvghlrdhorhhgpdhrtghpthhtohepihhoqdhurhhinhhgsehvghgvrhdrkhgvrhhn vghlrdhorhhgpdhrtghpthhtohepjhhorghnnhgvlhhkohhonhhgsehgmhgrihhlrdgtoh hmpdhrtghpthhtohepjhhoshgvfhesthhogihitghprghnuggrrdgtohhm X-ME-Proxy: Feedback-ID: i5c2e48a5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Jan 2025 08:24:45 -0500 (EST) Message-ID: <6a2dd294-da76-4dd1-b73f-283a628f78b4@bsbernd.com> Date: Thu, 23 Jan 2025 14:24:44 +0100 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 09/17] fuse: {io-uring} Make hash-list req unique finding functions non-static To: Luis Henriques , Bernd Schubert Cc: Miklos Szeredi , Jens Axboe , Pavel Begunkov , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Joanne Koong , Josef Bacik , Amir Goldstein , Ming Lei , David Wei References: <20250120-fuse-uring-for-6-10-rfc4-v10-0-ca7c5d1007c0@ddn.com> <20250120-fuse-uring-for-6-10-rfc4-v10-9-ca7c5d1007c0@ddn.com> <87y0z2etb9.fsf@igalia.com> From: Bernd Schubert Content-Language: en-US, de-DE, fr In-Reply-To: <87y0z2etb9.fsf@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/22/25 16:56, Luis Henriques wrote: > On Mon, Jan 20 2025, Bernd Schubert wrote: > >> fuse-over-io-uring uses existing functions to find requests based >> on their unique id - make these functions non-static. >> > > Single comment below. > >> Signed-off-by: Bernd Schubert >> Reviewed-by: Joanne Koong >> --- >> fs/fuse/dev.c | 6 +++--- >> fs/fuse/fuse_dev_i.h | 6 ++++++ >> fs/fuse/fuse_i.h | 5 +++++ >> fs/fuse/inode.c | 2 +- >> 4 files changed, 15 insertions(+), 4 deletions(-) >> >> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c >> index 8b03a540e151daa1f62986aa79030e9e7a456059..aa33eba51c51dff6af2cdcf60bed9c3f6b4bc0d0 100644 >> --- a/fs/fuse/dev.c >> +++ b/fs/fuse/dev.c >> @@ -220,7 +220,7 @@ u64 fuse_get_unique(struct fuse_iqueue *fiq) >> } >> EXPORT_SYMBOL_GPL(fuse_get_unique); >> >> -static unsigned int fuse_req_hash(u64 unique) >> +unsigned int fuse_req_hash(u64 unique) >> { >> return hash_long(unique & ~FUSE_INT_REQ_BIT, FUSE_PQ_HASH_BITS); >> } >> @@ -1910,7 +1910,7 @@ static int fuse_notify(struct fuse_conn *fc, enum fuse_notify_code code, >> } >> >> /* Look up request on processing list by unique ID */ >> -static struct fuse_req *request_find(struct fuse_pqueue *fpq, u64 unique) >> +struct fuse_req *fuse_request_find(struct fuse_pqueue *fpq, u64 unique) >> { >> unsigned int hash = fuse_req_hash(unique); >> struct fuse_req *req; >> @@ -1994,7 +1994,7 @@ static ssize_t fuse_dev_do_write(struct fuse_dev *fud, >> spin_lock(&fpq->lock); >> req = NULL; >> if (fpq->connected) >> - req = request_find(fpq, oh.unique & ~FUSE_INT_REQ_BIT); >> + req = fuse_request_find(fpq, oh.unique & ~FUSE_INT_REQ_BIT); >> >> err = -ENOENT; >> if (!req) { >> diff --git a/fs/fuse/fuse_dev_i.h b/fs/fuse/fuse_dev_i.h >> index 4a8a4feb2df53fb84938a6711e6bcfd0f1b9f615..599a61536f8c85b3631b8584247a917bda92e719 100644 >> --- a/fs/fuse/fuse_dev_i.h >> +++ b/fs/fuse/fuse_dev_i.h >> @@ -7,6 +7,7 @@ >> #define _FS_FUSE_DEV_I_H >> >> #include >> +#include > > Looking at these changes, it seems like this extra include isn't really > necessary. Is it a leftover from older revs? Hmm, right, I don't remember anymore why it ended up there. Not even needed for later patches, so yeah, probably a left-over. Thanks, Bernd