From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43A9C433F5 for ; Wed, 5 Jan 2022 17:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242387AbiAERjY (ORCPT ); Wed, 5 Jan 2022 12:39:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242352AbiAERjY (ORCPT ); Wed, 5 Jan 2022 12:39:24 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDD69C061245; Wed, 5 Jan 2022 09:39:23 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id bm14so165025565edb.5; Wed, 05 Jan 2022 09:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=dai/EtuC0U5fXbve0pJv7WC+HEVKC2J4wDtbrdgR9Ok=; b=dhFGi4aFGebYnc4nheSut1HsyM2au3pxRW9PquUm49HDormtIYw6WfkdpslQ4pdZYG cDSqhkpFObiX6MjH1U5EcqZ57oBf6VtEGrXvqCxWC/Z+YNnZfv+5CdSjI/dUnKOsRj/H bTJSXKgviComSchPnxsv6mhkiCI2Tm8ZyST7z1tVpvoxEoVnJYwWNPCj4LItOD27/Avr ZQJyCngfNYWg7t3mN90JjWkLuT2ScZCsoIGwidOzUFdY6NRooQvG3eaxNz+zpGhEmJ/e t/yGK1Xh9jclT3Wgu8WCC+youIBdkSEgM9rlQ+lKeCtX1gkMCAV7P45Htumqw4uDxGzo tGUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dai/EtuC0U5fXbve0pJv7WC+HEVKC2J4wDtbrdgR9Ok=; b=LlPk45L/6V3FvA+4y6TxUlMzqgdAElSIUDXdJ1Fyqzibo1x26Z3F9f3U9+a2BtaR9A xCzRjrwlijgrjjt5no6fmdzwPoqnw7R9tYfard/urbg5a3PqvKMZArWX/G+ofZ6wSB2H 4q/XPzRmurVvoNuEYhOmSdhSXzqfeMrVTsgUKX2DDUusTVBISWxpQ3pQopj76LmEFJ6Q EkSCyrs7jycikvHC9UTREnAd/lWUhY5TYp/S19fk5OMm/wEsUwzZL4JAxW2VYhGXSMnm MjhfnW5ymLRGx3xej2WIJoAWC2BJY9qCM/kqOt5r8UN3Gt0nSq0vRM8stchUnd44GlgL GVSg== X-Gm-Message-State: AOAM533Y2wRov/CYiceO+gEw2g8CiCFCQYvpHcilwYI242F6CW89Mtba Px/HaIWmEuK7x9LAHetkryQ= X-Google-Smtp-Source: ABdhPJz8/5M9GnaXaoZvZN4Yna5VIYG2nE/b1BoYspdCsOEvd2Y+nTGHGE97AXt8IZuhWFzXislh7Q== X-Received: by 2002:a05:6402:d05:: with SMTP id eb5mr54328127edb.345.1641404362318; Wed, 05 Jan 2022 09:39:22 -0800 (PST) Received: from [192.168.8.198] ([148.252.128.63]) by smtp.gmail.com with ESMTPSA id dt13sm12336020ejc.157.2022.01.05.09.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jan 2022 09:39:21 -0800 (PST) Message-ID: <6a692d3e-2b8d-bef6-d54d-9880980b245c@gmail.com> Date: Wed, 5 Jan 2022 17:37:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [syzbot] WARNING in signalfd_cleanup Content-Language: en-US To: Eric Biggers , Jens Axboe , io-uring@vger.kernel.org Cc: Eric Dumazet , syzbot , changbin.du@intel.com, Daniel Borkmann , David Miller , Heiner Kallweit , Jakub Kicinski , linux-fsdevel , LKML , netdev , syzkaller-bugs , Al Viro , Yajun Deng References: <000000000000c9a3fb05d4d787a3@google.com> From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/5/22 15:52, Eric Biggers wrote: > [+io_uring list and maintainers] > > This appears to be the known bug in io_uring where it doesn't POLLFREE > notifications. See previous discussion: > https://lore.kernel.org/all/4a472e72-d527-db79-d46e-efa9d4cad5bb@kernel.dk/ We've got some fixing and groundwork done, but not POLLFREE yet. Great to have a repro, thanks > On Wed, Jan 05, 2022 at 07:42:10AM -0800, 'Eric Dumazet' via syzkaller-bugs wrote: >> On Wed, Jan 5, 2022 at 7:37 AM syzbot >> wrote: >>> >>> Hello, >>> >>> syzbot found the following issue on: >>> >>> HEAD commit: 6b8d4927540e Add linux-next specific files for 20220104 >>> git tree: linux-next >>> console output: https://syzkaller.appspot.com/x/log.txt?x=159d88e3b00000 >>> kernel config: https://syzkaller.appspot.com/x/.config?x=45c9bbbf2ae8e3d3 >>> dashboard link: https://syzkaller.appspot.com/bug?extid=5426c7ed6868c705ca14 >>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 >>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=117be65db00000 >>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15a75c8db00000 >>> >> >> C repro looks legit, point to an io_uring issue. >> >>> The issue was bisected to: >> >> Please ignore the bisection. >> >>> >>> commit e4b8954074f6d0db01c8c97d338a67f9389c042f >>> Author: Eric Dumazet >>> Date: Tue Dec 7 01:30:37 2021 +0000 >>> >>> netlink: add net device refcount tracker to struct ethnl_req_info >>> >>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12bca4e3b00000 >>> final oops: https://syzkaller.appspot.com/x/report.txt?x=11bca4e3b00000 >>> console output: https://syzkaller.appspot.com/x/log.txt?x=16bca4e3b00000 >>> >>> IMPORTANT: if you fix the issue, please add the following tag to the commit: >>> Reported-by: syzbot+5426c7ed6868c705ca14@syzkaller.appspotmail.com >>> Fixes: e4b8954074f6 ("netlink: add net device refcount tracker to struct ethnl_req_info") >>> >>> ------------[ cut here ]------------ >>> WARNING: CPU: 0 PID: 3604 at kernel/sched/wait.c:245 __wake_up_pollfree+0x40/0x50 kernel/sched/wait.c:246 >>> Modules linked in: >>> CPU: 0 PID: 3604 Comm: syz-executor714 Not tainted 5.16.0-rc8-next-20220104-syzkaller #0 >>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 >>> RIP: 0010:__wake_up_pollfree+0x40/0x50 kernel/sched/wait.c:245 >>> Code: f3 ff ff 48 8d 6b 40 48 b8 00 00 00 00 00 fc ff df 48 89 ea 48 c1 ea 03 80 3c 02 00 75 11 48 8b 43 40 48 39 c5 75 03 5b 5d c3 <0f> 0b 5b 5d c3 48 89 ef e8 13 d8 69 00 eb e5 cc 48 c1 e7 06 48 63 >>> RSP: 0018:ffffc90001aaf9f8 EFLAGS: 00010083 >>> RAX: ffff88801cd623f0 RBX: ffff88801bec8048 RCX: 0000000000000000 >>> RDX: 1ffff110037d9011 RSI: 0000000000000004 RDI: 0000000000000001 >>> RBP: ffff88801bec8088 R08: 0000000000000000 R09: ffff88801bec804b >>> R10: ffffed10037d9009 R11: 0000000000000000 R12: ffff88801bec8040 >>> R13: ffff88801e029d40 R14: dffffc0000000000 R15: ffff88807eb50000 >>> FS: 00005555573ad300(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000 >>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> CR2: 00000000200000c0 CR3: 000000001e5e4000 CR4: 00000000003506f0 >>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >>> Call Trace: >>> >>> wake_up_pollfree include/linux/wait.h:271 [inline] >>> signalfd_cleanup+0x42/0x60 fs/signalfd.c:38 >>> __cleanup_sighand kernel/fork.c:1596 [inline] >>> __cleanup_sighand+0x72/0xb0 kernel/fork.c:1593 >>> __exit_signal kernel/exit.c:159 [inline] >>> release_task+0xc02/0x17e0 kernel/exit.c:200 >>> wait_task_zombie kernel/exit.c:1117 [inline] >>> wait_consider_task+0x2fa6/0x3b80 kernel/exit.c:1344 >>> do_wait_thread kernel/exit.c:1407 [inline] >>> do_wait+0x6ca/0xce0 kernel/exit.c:1524 >>> kernel_wait4+0x14c/0x260 kernel/exit.c:1687 >>> __do_sys_wait4+0x13f/0x150 kernel/exit.c:1715 >>> do_syscall_x64 arch/x86/entry/common.c:50 [inline] >>> do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 >>> entry_SYSCALL_64_after_hwframe+0x44/0xae >>> RIP: 0033:0x7facd6682386 >>> Code: 0f 1f 40 00 31 c9 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 49 89 ca 64 8b 04 25 18 00 00 00 85 c0 75 11 b8 3d 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 5a c3 90 48 83 ec 28 89 54 24 14 48 89 74 24 >>> RSP: 002b:00007ffdb91adef8 EFLAGS: 00000246 ORIG_RAX: 000000000000003d >>> RAX: ffffffffffffffda RBX: 000000000000c646 RCX: 00007facd6682386 >>> RDX: 0000000040000001 RSI: 00007ffdb91adf14 RDI: 00000000ffffffff >>> RBP: 0000000000000f17 R08: 0000000000000032 R09: 00007ffdb91ec080 >>> R10: 0000000000000000 R11: 0000000000000246 R12: 431bde82d7b634db >>> R13: 00007ffdb91adf14 R14: 0000000000000000 R15: 0000000000000000 >>> >>> >>> >>> --- >>> This report is generated by a bot. It may contain errors. >>> See https://goo.gl/tpsmEJ for more information about syzbot. >>> syzbot engineers can be reached at syzkaller@googlegroups.com. >>> >>> syzbot will keep track of this issue. See: >>> https://goo.gl/tpsmEJ#status for how to communicate with syzbot. >>> For information about bisection process see: https://goo.gl/tpsmEJ#bisection >>> syzbot can test patches for this issue, for details see: >>> https://goo.gl/tpsmEJ#testing-patches >> >> -- >> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/CANn89iK3tP3rANSWM7_%3DimMeMcUknT0U2GyfA9W4v12ad6_PkQ%40mail.gmail.com. -- Pavel Begunkov