From: Pavel Begunkov <[email protected]>
To: [email protected]
Cc: Jens Axboe <[email protected]>,
[email protected], Dylan Yudaken <[email protected]>,
Stefan Metzmacher <[email protected]>
Subject: [RFC 2/2] io_uring/net: allow to override notification tag
Date: Tue, 16 Aug 2022 08:42:01 +0100 [thread overview]
Message-ID: <6aa0c662a3fec17a1ade512e7bbb519aa49e6e4d.1660635140.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>
Considering limited amount of slots some users struggle with
registration time notification tag assignment as it's hard to manage
notifications using sequence numbers. Add a simple feature that copies
sqe->user_data of a send(+flush) request into the notification CQE it
flushes (and only when it's flushes).
Signed-off-by: Pavel Begunkov <[email protected]>
---
include/uapi/linux/io_uring.h | 4 ++++
io_uring/net.c | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
index 20368394870e..91e7944c9c78 100644
--- a/include/uapi/linux/io_uring.h
+++ b/include/uapi/linux/io_uring.h
@@ -280,11 +280,15 @@ enum io_uring_op {
*
* IORING_RECVSEND_NOTIF_FLUSH Flush a notification after a successful
* successful. Only for zerocopy sends.
+ *
+ * IORING_RECVSEND_NOTIF_COPY_TAG Copy request's user_data into the notification
+ * completion even if it's flushed.
*/
#define IORING_RECVSEND_POLL_FIRST (1U << 0)
#define IORING_RECV_MULTISHOT (1U << 1)
#define IORING_RECVSEND_FIXED_BUF (1U << 2)
#define IORING_RECVSEND_NOTIF_FLUSH (1U << 3)
+#define IORING_RECVSEND_NOTIF_COPY_TAG (1U << 4)
/* cqe->res mask for extracting the notification sequence number */
#define IORING_NOTIF_SEQ_MASK 0xFFFFU
diff --git a/io_uring/net.c b/io_uring/net.c
index bd3fad9536ef..4d271a269979 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -858,7 +858,9 @@ int io_sendzc_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
zc->flags = READ_ONCE(sqe->ioprio);
if (zc->flags & ~(IORING_RECVSEND_POLL_FIRST |
- IORING_RECVSEND_FIXED_BUF | IORING_RECVSEND_NOTIF_FLUSH))
+ IORING_RECVSEND_FIXED_BUF |
+ IORING_RECVSEND_NOTIF_FLUSH |
+ IORING_RECVSEND_NOTIF_COPY_TAG))
return -EINVAL;
if (zc->flags & IORING_RECVSEND_FIXED_BUF) {
unsigned idx = READ_ONCE(sqe->buf_index);
@@ -1024,6 +1026,8 @@ int io_sendzc(struct io_kiocb *req, unsigned int issue_flags)
if (ret == -ERESTARTSYS)
ret = -EINTR;
} else if (zc->flags & IORING_RECVSEND_NOTIF_FLUSH) {
+ if (zc->flags & IORING_RECVSEND_NOTIF_COPY_TAG)
+ notif->cqe.user_data = req->cqe.user_data;
io_notif_slot_flush_submit(notif_slot, 0);
}
--
2.37.0
next prev parent reply other threads:[~2022-08-16 9:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 7:41 [RFC 0/2] io_uring zc notification tag override Pavel Begunkov
2022-08-16 7:42 ` [RFC 1/2] io_uring/notif: change notif CQE uapi format Pavel Begunkov
2022-08-16 8:14 ` Stefan Metzmacher
2022-08-16 7:42 ` Pavel Begunkov [this message]
2022-08-16 8:23 ` [RFC 2/2] io_uring/net: allow to override notification tag Stefan Metzmacher
2022-08-17 12:42 ` Pavel Begunkov
2022-08-18 18:13 ` Stefan Metzmacher
2022-08-19 11:42 ` Pavel Begunkov
2022-08-19 12:36 ` Stefan Metzmacher
2022-08-22 11:49 ` Pavel Begunkov
2022-08-16 8:37 ` Dylan Yudaken
2022-08-17 10:48 ` Pavel Begunkov
2022-08-17 12:04 ` Dylan Yudaken
2022-08-17 12:44 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aa0c662a3fec17a1ade512e7bbb519aa49e6e4d.1660635140.git.asml.silence@gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox