public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Ming Lei <[email protected]>
Cc: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [bug] kernel panic when running ublk selftest on next-20250321
Date: Fri, 21 Mar 2025 09:13:54 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <Z91_v1Ce2sCFBNSG@fedora>

On 3/21/25 9:03 AM, Ming Lei wrote:
> On Fri, Mar 21, 2025 at 08:40:57AM -0600, Jens Axboe wrote:
>> On 3/21/25 8:40 AM, Pavel Begunkov wrote:
>>> On 3/21/25 14:33, Ming Lei wrote:
>>>> Hello,
>>>>
>>>> When running ublk selftest on today's next tree, the following kernel
>>>> panic is triggered immediately:
>>>
>>> Jens already stumbled on that one, it's likely because the
>>> cached structure is not zeroed on alloc. I believe the
>>> troubled patch is removed from the tree for now.
>>
>> Yep, ran into the same thing this morning, and yep the two last patches
>> in that series got dropped until this is resolved. Ming, if you use my
>> current for-next branch, it should all be good again.
> 
> Yeah, looks everything is good after reverting the following two patches:
> 
> Revert "io_uring/cmd: add iovec cache for commands"
> Revert "io_uring/cmd: introduce io_uring_cmd_import_fixed_vec"
> 
> BTW I feel io_uring_cmd_import_fixed_vec is useful for using ublk
> zc to write stacking target, plain readv/writev works just
> fine without zc.

I think Pavel is looking at the issue right now, so both may get
reintroduced for the 6.15 merge window. That said, we don't strictly
need the caching, we can always pile that on later. The vectored import
is going to be useful, agree, and can stand on its own.

-- 
Jens Axboe

      reply	other threads:[~2025-03-21 15:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 14:33 [bug] kernel panic when running ublk selftest on next-20250321 Ming Lei
2025-03-21 14:40 ` Pavel Begunkov
2025-03-21 14:40   ` Jens Axboe
2025-03-21 15:03     ` Ming Lei
2025-03-21 15:13       ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox