public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>,
	[email protected], [email protected]
Subject: Re: [PATCH v3 0/3] Inline sqe_submit
Date: Wed, 6 Nov 2019 15:47:14 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 11/6/19 3:41 PM, Pavel Begunkov wrote:
> The idea is to not pass struct sqe_submit as a separate entity,
> but always use req->submit instead, so there will be less stuff to
> care about.
> 
> Also, I've got steady +1% throughput improvement for nop tests.
> Though, it's highly system-dependent, and I wouldn't count on it.
> 
> v2: fix use-after-free catched by Jens
> 
> v3: -EAGAIN, in case submission failed
> 
> Pavel Begunkov (3):
>    io_uring: allocate io_kiocb upfront
>    io_uring: Use submit info inlined into req
>    io_uring: use inlined struct sqe_submit
> 
>   fs/io_uring.c | 134 +++++++++++++++++++++++++-------------------------
>   1 file changed, 67 insertions(+), 67 deletions(-)

This looks good to me now, thanks! Applied.

-- 
Jens Axboe


      parent reply	other threads:[~2019-11-06 22:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 22:41 [PATCH v3 0/3] Inline sqe_submit Pavel Begunkov
2019-11-06 22:41 ` [PATCH v3 1/3] io_uring: allocate io_kiocb upfront Pavel Begunkov
2019-11-06 22:47   ` Pavel Begunkov
2019-11-06 22:41 ` [PATCH v3 2/3] io_uring: Use submit info inlined into req Pavel Begunkov
2019-11-06 22:41 ` [PATCH v3 3/3] io_uring: use inlined struct sqe_submit Pavel Begunkov
2019-11-06 22:47 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox