public inbox for [email protected]
 help / color / mirror / Atom feed
From: Xan Charbonnet <[email protected]>
To: Pavel Begunkov <[email protected]>,
	Salvatore Bonaccorso <[email protected]>,
	[email protected], Jens Axboe <[email protected]>
Cc: Bernhard Schmidt <[email protected]>,
	[email protected], [email protected]
Subject: Re: Bug#1093243: Upgrade to 6.1.123 kernel causes mariadb hangs
Date: Thu, 23 Jan 2025 20:10:48 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 1/23/25 20:49, Salvatore Bonaccorso wrote:
> Additionally please try with 6.1.120 and revert this commit
>
> 3ab9326f93ec ("io_uring: wake up optimisations")
>
> (which landed in 6.1.120).
>
> If that solves the problem maybe we miss some prequisites in the 6.1.y
> series here?


I hope I did all this right.  I found this:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=3181e22fb79910c7071e84a43af93ac89e8a7106

and attempted to undo that change in the vanilla 6.1.124 source by 
making the following change to io_uring/io_uring.c:

585,594d584
< static inline void __io_cq_unlock_post_flush(struct io_ring_ctx *ctx)
<       __releases(ctx->completion_lock)
< {
<       io_commit_cqring(ctx);
<       spin_unlock(&ctx->completion_lock);
<       io_commit_cqring_flush(ctx);
<       if (!(ctx->flags & IORING_SETUP_DEFER_TASKRUN))
<               __io_cqring_wake(ctx);
< }
<
1352c1342
<       __io_cq_unlock_post_flush(ctx);
---
 >         __io_cq_unlock_post(ctx);


I rebooted into the resulting kernel and am happy to report that the 
problem did NOT occur!


  reply	other threads:[~2025-01-24  2:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173706089225.4380.9492796104667651797.reportbug@backup22.biblionix.com>
     [not found] ` <[email protected]>
     [not found]   ` <[email protected]>
     [not found]     ` <[email protected]>
2025-01-23 20:05       ` Bug#1093243: Upgrade to 6.1.123 kernel causes mariadb hangs Salvatore Bonaccorso
2025-01-23 20:26         ` Jens Axboe
     [not found] ` <[email protected]>
2025-01-23 20:49   ` Salvatore Bonaccorso
2025-01-23 23:20     ` Pavel Begunkov
2025-01-24  2:10       ` Xan Charbonnet [this message]
2025-01-24  5:24       ` Salvatore Bonaccorso
2025-01-24 10:33         ` Pavel Begunkov
2025-01-24 16:30           ` Xan Charbonnet
2025-01-24 18:40             ` Pavel Begunkov
2025-01-24 20:33               ` Salvatore Bonaccorso
2025-01-24 20:51                 ` Jens Axboe
2025-01-26 22:48                   ` Xan Charbonnet
2025-01-27 16:38                     ` Xan Charbonnet
2025-01-27 17:21                       ` Pavel Begunkov
2025-01-27 16:49                     ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6baae9c9-b296-47b8-a7e2-56368bd7e84a@charbonnet.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox