public inbox for [email protected]
 help / color / mirror / Atom feed
From: Stefan Metzmacher <[email protected]>
To: Michael Tokarev <[email protected]>,
	[email protected],
	io-uring <[email protected]>
Subject: Re: samba does not work with liburing 2.3
Date: Tue, 8 Nov 2022 14:26:02 +0100	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Am 08.11.22 um 13:56 schrieb Michael Tokarev via samba-technical:
> 08.11.2022 13:25, Michael Tokarev via samba-technical wrote:
>> FWIW, samba built against the relatively new liburing-2.3 does not
>> work right, io_uring-enabled samba just times out in various i/o
>> operations (eg from smbclient) when liburing used at compile time
>> was 2.3. It works fine with liburing 2.2.
> 
> This turned out to be debian packaging issue, but it might affect
> others too. liburing 2.3 breaks ABI by changing layout of the main
> struct io_uring object in a significant way.
> 
> http://bugs.debian.org/1023654

I don't see where this changes the struct size:

-       unsigned pad[4];
+       unsigned ring_mask;
+       unsigned ring_entries;
+
+       unsigned pad[2];

But I see a problem when you compile against 2.3 and run against 2.2
as the new values are not filled.

The problem is the mixture of inline and non-inline functions...

The packaging should make sure it requires the version is build against...

metze



       reply	other threads:[~2022-11-08 13:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[email protected]>
     [not found] ` <[email protected]>
2022-11-08 13:26   ` Stefan Metzmacher [this message]
2022-11-08 13:42     ` samba does not work with liburing 2.3 Michael Tokarev
2022-11-08 13:43     ` Ammar Faizi
2022-11-08 19:18       ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox