From: Jens Axboe <[email protected]>
To: Dylan Yudaken <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Cc: [email protected]
Subject: Re: [PATCH] io_uring: make tracing format consistent
Date: Tue, 15 Mar 2022 14:51:05 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/15/22 2:48 PM, Dylan Yudaken wrote:
> Make the tracing formatting for user_data and flags consistent.
>
> Having consistent formatting allows one for example to grep for a specific
> user_data/flags and be able to trace a single sqe through easily.
>
> Change user_data to be %llu everywhere, and flags to be %u. Additionally
> remove the '=' for flags in io_uring_req_failed, again for consistency.
Shouldn't we rather make flags be %x everywhere? Doesn't make a lot of
sense to have a flag based value be in decimal.
Ditto on user_data actually, I would guess the most common use case is
stuffing an address in there. And if it's a masked value, then it's
easier to read in hex too.
Hmm?
--
Jens Axboe
prev parent reply other threads:[~2022-03-15 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 20:48 [PATCH] io_uring: make tracing format consistent Dylan Yudaken
2022-03-15 20:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox