From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64E7DC33C9E for ; Wed, 29 Jan 2020 00:22:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 253042173E for ; Wed, 29 Jan 2020 00:22:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iOD8c6ch" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbgA2AWU (ORCPT ); Tue, 28 Jan 2020 19:22:20 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:39169 "EHLO mail-wm1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbgA2AWU (ORCPT ); Tue, 28 Jan 2020 19:22:20 -0500 Received: by mail-wm1-f53.google.com with SMTP id c84so4515386wme.4; Tue, 28 Jan 2020 16:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to; bh=a73NlMd5hAkwdIBksnvzH+ZRq1ht+oXuyLDU9fSttAk=; b=iOD8c6chUSwNbWPzV8I8HkpmTHBvT9xso6worn0r0jxM1MJWOhROkiMxWJInWCZwcO g6kw/jo4NewxNpA3uloCDJ61n8zN8JvyqjznKrb9UE1toGM69F1UzBYKl9GiF13AZRrm dzwPf0/KK9+4FwECZZPzFYkjwdl3jQi+k320/nCSbZFKIOmM8dfNveIPCzrlebGIguHC qfA1+smIexxY4OJPOHq3lzbHTK79WJU/bRYvp5woLEsnJOChmroF64I8FwbOLdEjx10y lblBMihjUOKFHa3qItF/oHe+i1pThhs9D8MPLOUAWQFLi6nslebBt3YTpmo5LK17tGNK sxZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to; bh=a73NlMd5hAkwdIBksnvzH+ZRq1ht+oXuyLDU9fSttAk=; b=qQhl3p59nG/Gg2C02CnbOVcM/8YUStJ6711n3kZgp94kwv9FxuSxM0cbH9R5gSNlKF AuK2zxWUpfQHMVeDx1iUDMwmqvAUxMWn1rMNbvzv/42jaRDOi51VfifyrdlKTh416Vgy qx2M7V8NrjK+IWAK02kDY0cATkvMySa5BIYs+AOCIsosj6ijuXEUNp0iCxHYoeyomSRW 1QMK2sduDidukXuf+iET+AS1AD3+R3oemazNQKfDEJ8iPWJFFIdA8sy8LL2Ib3F7JIx/ 1qR/CMjnWJjOrBnjJIi3r5wBTm3d/03RpjkLDUFOolqCCi3E9cHu48mdTa58Chll+fE1 iGtg== X-Gm-Message-State: APjAAAX/EgKbolyBST5rl5BEWrzZKgeyn6wI9ldTSmm6tz+xT+DGGloA Ag2YIgGu2caTjq/PltcuNVflpS30 X-Google-Smtp-Source: APXvYqwtPa3ebpEBfzSGOf62eTBgXU8oYBOdGNOpLWznwn3FzCRbWUQ5s+qxsawEg+vXJrwRq99cNQ== X-Received: by 2002:a1c:4d07:: with SMTP id o7mr7922621wmh.174.1580257336819; Tue, 28 Jan 2020 16:22:16 -0800 (PST) Received: from [192.168.43.59] ([109.126.145.157]) by smtp.gmail.com with ESMTPSA id s10sm516915wrw.12.2020.01.28.16.22.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 16:22:16 -0800 (PST) Subject: Re: IORING_REGISTER_CREDS[_UPDATE]() and credfd_create()? To: Jens Axboe , Stefan Metzmacher Cc: io-uring , Linux API Mailing List References: <688e187a-75dd-89d9-921c-67de228605ce@samba.org> <1ac31828-e915-6180-cdb4-36685442ea75@kernel.dk> <0d4f43d8-a0c4-920b-5b8f-127c1c5a3fad@kernel.dk> <2d7e7fa2-e725-8beb-90b9-6476d48bdb33@gmail.com> <6c401e23-de7c-1fc1-4122-33d53fcf9700@kernel.dk> <35eebae7-76dd-52ee-58b2-4f9e85caee40@kernel.dk> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <6e5ab6bf-6ff1-14df-1988-a80a7c6c9294@gmail.com> Date: Wed, 29 Jan 2020 03:21:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IxCXwQS2qPJ4CdqPK7LaTW20A24t4bFhg" Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IxCXwQS2qPJ4CdqPK7LaTW20A24t4bFhg Content-Type: multipart/mixed; boundary="ifVV2pBJdDMlWRXC5H7I9Ds7Auciv5DLJ"; protected-headers="v1" From: Pavel Begunkov To: Jens Axboe , Stefan Metzmacher Cc: io-uring , Linux API Mailing List Message-ID: <6e5ab6bf-6ff1-14df-1988-a80a7c6c9294@gmail.com> Subject: Re: IORING_REGISTER_CREDS[_UPDATE]() and credfd_create()? References: <688e187a-75dd-89d9-921c-67de228605ce@samba.org> <1ac31828-e915-6180-cdb4-36685442ea75@kernel.dk> <0d4f43d8-a0c4-920b-5b8f-127c1c5a3fad@kernel.dk> <2d7e7fa2-e725-8beb-90b9-6476d48bdb33@gmail.com> <6c401e23-de7c-1fc1-4122-33d53fcf9700@kernel.dk> <35eebae7-76dd-52ee-58b2-4f9e85caee40@kernel.dk> In-Reply-To: --ifVV2pBJdDMlWRXC5H7I9Ds7Auciv5DLJ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 29/01/2020 03:20, Jens Axboe wrote: > On 1/28/20 5:10 PM, Pavel Begunkov wrote: >>>>> Checked out ("don't use static creds/mm assignments") >>>>> >>>>> 1. do we miscount cred refs? We grab one in get_current_cred() for = each async >>>>> request, but if (worker->creds !=3D work->creds) it will never be p= ut. >>>> >>>> Yeah I think you're right, that needs a bit of fixing up. >>> >> >> Hmm, it seems it leaks it unconditionally, as it grabs in a ref in >> override_creds(). >> >=20 > We grab one there, and an extra one. Then we drop one of them inline, > and the other in __io_req_aux_free(). >=20 Yeah, with the last patch it should make it even --=20 Pavel Begunkov --ifVV2pBJdDMlWRXC5H7I9Ds7Auciv5DLJ-- --IxCXwQS2qPJ4CdqPK7LaTW20A24t4bFhg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+6JuPTjTbx479o3OWt5b1Glr+6UFAl4w0BAACgkQWt5b1Glr +6UVZxAAqtyQo0bEPEkxePdczP3/QBzaH0sR0xAPY9MkrLRguWxUtzc+b5bey8NM C8r4ZK0N8/Qpzp6pLfPHuxRg1brZcq5hYpSiV5SdxqiTLZ9ck7tZSdjBSc1XEpjd HnIQPHoEA3zy4cQN/+XZYOEMxRuE56T4EUeg8N5Ecal8R3SGZvtMJa/ByfmTNhEp ROwWixMJ1CTTM8QnXU+bShTve+5qz2COJSOo08js/dhp7X75dV8d3QskkyCKRNVn JjDpo4RDHczJ/bHa9CEsHPEVr9VaKx3uxwI2PDuSQ0g09MGM945i29/NBvbZ151Z FpJ+dHE0k+42o+dUM6lLUk6hqBWmBY0FUZrYrb26vo+j1zi2ER85P1JpPkO4Uu9t R1gEuY0clxmyqwILYzN0/q7w6+yY/7XsgDVOrDm0X5TIrINgzdm0xdXVU6lQGKXT 8XMGj6cGgt15+cp5mefPGkkUE/TjNgb/pstxMnVUTQcvFKGs+LrDb283kgFIgGTL CBSW1kz1UZVM+k/4oJDK3CAlX9ob8WywreOHrgjdoh1LKZAjHIhaC5jWyQY6KVMi QAhGB+3UN8kslL0QD7zS0boqHmlrBqLdotSXGwsoisZMFiDALNDXzIOJYZrDcfDU FIwfznHLyhkh7892vCws2K6tVkOOKGgXWLabWyU926ty7o9NfkU= =4Ptb -----END PGP SIGNATURE----- --IxCXwQS2qPJ4CdqPK7LaTW20A24t4bFhg--