From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD89C2D0A3 for ; Mon, 16 Nov 2020 16:52:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 251FB20773 for ; Mon, 16 Nov 2020 16:52:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jAJkCiDX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730422AbgKPQvn (ORCPT ); Mon, 16 Nov 2020 11:51:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731935AbgKPQvn (ORCPT ); Mon, 16 Nov 2020 11:51:43 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBAABC0613CF for ; Mon, 16 Nov 2020 08:51:42 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id c17so19389586wrc.11 for ; Mon, 16 Nov 2020 08:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=x2T3uGX7RuFzjP65eVAxvNmUNEicko6e3tu30mMdl+M=; b=jAJkCiDXqbZtvjFAmjH3zCBCwD2fBThRqARqY7OPKmndMrdL6I/JHN2k1UsW5FddzW InvwEa+9s2WLwBRUkz7DhRkeqqmyZGK+IkwVjUQmPhNj46dYRLJSk/L4qNJBsOODBemY RNCbydBZfPpW+I74qrGMFAQlMYr8CCXaLR+NPXyp4vCWskskKSJX9VzIwQmvOYApzDRn izwk+2FCJGh8nsCptWK/IAOOLZIlBZMkEZunUe56czWGc4T+9RhiFkqIKEt+i3WQ345P zTCJ98YeS/JZhtJE3b65dUs8WIyCIt1CZYody9jUP3FkOf3SKlkbtc06WzvNCReh0iYO tEZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x2T3uGX7RuFzjP65eVAxvNmUNEicko6e3tu30mMdl+M=; b=nAsNkphwpRCQMd72CKiaYnA9bkOqT0hC2fkZ6Sb/VZHbEdm0AeN3BZWLvZ3yC0NTsC cWRQLRFHDjGN16MZ1kDsSI/VLSgyxdWnTduUfYFM0eH0MtEmf1z2irefuY53rg06cpZH ArFt2GjBVw3sV762uQA2JAuhurH0NvBW7gGYjJmOwTgmSd/7Gt+hVFyvfi7CFB9ZD40r ZnLRw6DPuaN7okwZY4j+yODe9qa93BYbVl41Da6YW7aOYDG93NCZwMLThkk2o/wmrz8p Uz8pwujqfQBqZjDKPFbXw/ON1Wis3nBrsN+TnHl/JHmby3GstJXUaaLennbjIRlNSMhq iUeQ== X-Gm-Message-State: AOAM530G2egh1XwUN8zCsSjcv29mrqaWKasnbV20cLcV2P7mvpI3i28n W0g7Mz4/Tam2PnvY6VqUdRazwJdB5R3y5Q== X-Google-Smtp-Source: ABdhPJyHLOCCLNELCQL3w5GDf+CcGgadYsFjz/KIcD9MzZXFX2ljwpl42MuZDoI3h+QAoTJfYeMN3Q== X-Received: by 2002:adf:f24b:: with SMTP id b11mr21471207wrp.342.1605545501321; Mon, 16 Nov 2020 08:51:41 -0800 (PST) Received: from [192.168.1.33] (host109-152-100-135.range109-152.btcentralplus.com. [109.152.100.135]) by smtp.gmail.com with ESMTPSA id m22sm24805674wrb.97.2020.11.16.08.51.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2020 08:51:40 -0800 (PST) To: Jens Axboe , io-uring@vger.kernel.org References: <463ac36b-974d-f88c-d178-6e4d24fa4c93@kernel.dk> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: [PATCH 1/1] io_uring: replace inflight_wait with tctx->wait Message-ID: <6f58c74f-19d8-497b-e73e-8655a29601a8@gmail.com> Date: Mon, 16 Nov 2020 16:48:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <463ac36b-974d-f88c-d178-6e4d24fa4c93@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 16/11/2020 16:33, Jens Axboe wrote: > On 11/15/20 5:56 AM, Pavel Begunkov wrote: >> As tasks now cancel only theirs requests, and inflight_wait is awaited >> only in io_uring_cancel_files(), which should be called with ->in_idle >> set, instead of keeping a separate inflight_wait use tctx->wait. >> >> That will add some spurious wakeups but actually is safer from point of >> not hanging the task. >> >> e.g. >> task1 | IRQ >> | *start* io_complete_rw_common(link) >> | link: req1 -> req2 -> req3(with files) >> *cancel_files() | >> io_wq_cancel(), etc. | >> | put_req(link), adds to io-wq req2 >> schedule() | >> >> So, task1 will never try to cancel req2 or req3. If req2 is >> long-standing (e.g. read(empty_pipe)), this may hang. > > This looks like it's against 5.11, but also looks like we should add > it for 5.10? Yeah, 5.10 completely slipped my mind, I'll resend -- Pavel Begunkov