From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>,
io-uring@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH V2 0/2] nvme: optimize passthrough IOPOLL completion for local ring context
Date: Mon, 19 Jan 2026 08:22:09 -0700 [thread overview]
Message-ID: <6f703719-ee33-4fd9-bcbf-afb15967a494@kernel.dk> (raw)
In-Reply-To: <9859f637-d8f9-48e0-98ba-42cc6255c73b@kernel.dk>
On 1/19/26 8:19 AM, Jens Axboe wrote:
> On 1/16/26 12:46 AM, Ming Lei wrote:
>> Hello,
>>
>> The 1st patch passes `struct io_comp_batch *` to rq_end_io_fn callback.
>>
>> The 2nd patch completes IOPOLL uring_cmd inline in case of local ring
>> context, and improves IOPS by ~10%.
>>
>>
>> V2:
>> - pass `struct io_comp_batch *` to ->end_io() directly via
>> blk_mq_end_request_batch().
>
> This is a much better approach indeed. Looks good to me.
Forgot to mention, Keith can you let me know if this looks good to you
too?
--
Jens Axboe
next prev parent reply other threads:[~2026-01-19 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260116074819epcas5p37afab1cd05fdf9e0555a14b5fe89c2dd@epcas5p3.samsung.com>
2026-01-16 7:46 ` [PATCH V2 0/2] nvme: optimize passthrough IOPOLL completion for local ring context Ming Lei
2026-01-16 7:46 ` [PATCH V2 1/2] block: pass io_comp_batch to rq_end_io_fn callback Ming Lei
2026-01-16 7:46 ` [PATCH V2 2/2] nvme/io_uring: optimize IOPOLL completions for local ring context Ming Lei
2026-01-19 15:07 ` [PATCH V2 0/2] nvme: optimize passthrough IOPOLL completion " Kanchan Joshi
2026-01-19 15:19 ` Jens Axboe
2026-01-19 15:22 ` Jens Axboe [this message]
2026-01-20 17:07 ` Keith Busch
2026-01-20 17:24 ` Jens Axboe
2026-01-20 17:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f703719-ee33-4fd9-bcbf-afb15967a494@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox