* [PATCH next] io_uring/rsrc: fix error code in io_clone_buffers()
@ 2024-10-30 9:55 Dan Carpenter
2024-10-30 13:09 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2024-10-30 9:55 UTC (permalink / raw)
To: Jens Axboe; +Cc: Pavel Begunkov, io-uring, linux-kernel, kernel-janitors
Return -ENOMEM if the allocation fails. Don't return success.
Fixes: c0b9c5097cbc ("io_uring/rsrc: unify file and buffer resource tables")
Signed-off-by: Dan Carpenter <[email protected]>
---
io_uring/rsrc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 784fd1ca6031..f317f39e8b95 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -977,8 +977,10 @@ static int io_clone_buffers(struct io_ring_ctx *ctx, struct io_ring_ctx *src_ctx
dst_node = rsrc_empty_node;
} else {
dst_node = io_rsrc_node_alloc(ctx, &data, index, IORING_RSRC_BUFFER);
- if (!dst_node)
+ if (!dst_node) {
+ ret = -ENOMEM;
goto out_put_free;
+ }
refcount_inc(&src_node->buf->refs);
dst_node->buf = src_node->buf;
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] io_uring/rsrc: fix error code in io_clone_buffers()
2024-10-30 9:55 [PATCH next] io_uring/rsrc: fix error code in io_clone_buffers() Dan Carpenter
@ 2024-10-30 13:09 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2024-10-30 13:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Pavel Begunkov, io-uring, linux-kernel, kernel-janitors
On Wed, 30 Oct 2024 12:55:06 +0300, Dan Carpenter wrote:
> Return -ENOMEM if the allocation fails. Don't return success.
>
>
Applied, thanks!
[1/1] io_uring/rsrc: fix error code in io_clone_buffers()
commit: 0f576012ae2ff08009ce91e2294832e2b88aba06
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-30 13:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-30 9:55 [PATCH next] io_uring/rsrc: fix error code in io_clone_buffers() Dan Carpenter
2024-10-30 13:09 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox