From: Jens Axboe <[email protected]>
To: "Darrick J. Wong" <[email protected]>
Cc: [email protected], [email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH 6/9] fs: add IOCB flags related to passing back dio completions
Date: Fri, 21 Jul 2023 10:43:53 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 7/21/23 10:30?AM, Jens Axboe wrote:
> On 7/21/23 10:28?AM, Darrick J. Wong wrote:
>>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>>> index 6867512907d6..60e2b4ecfc4d 100644
>>> --- a/include/linux/fs.h
>>> +++ b/include/linux/fs.h
>>> @@ -338,6 +338,20 @@ enum rw_hint {
>>> #define IOCB_NOIO (1 << 20)
>>> /* can use bio alloc cache */
>>> #define IOCB_ALLOC_CACHE (1 << 21)
>>> +/*
>>> + * IOCB_DIO_CALLER_COMP can be set by the iocb owner, to indicate that the
>>> + * iocb completion can be passed back to the owner for execution from a safe
>>> + * context rather than needing to be punted through a workqueue.If this If this
>>
>> "...through a workqueue. If this flag is set..."
>>
>> Need a space after the period, and delete one of the "If this".
>>
>> With that fixed,
>> Reviewed-by: Darrick J. Wong <[email protected]>
>
> Thanks - same ask on the edit. Or let me know if:
>
> a) you're fine with staging this in a separate branch for 6.6, or
> b) you want a v5a/v6 edition posted
>
> Either way is no trouble for me, just wary of spamming...
FWIW, here's the updated branch:
https://git.kernel.dk/cgit/linux/log/?h=xfs-async-dio.5
--
Jens Axboe
next prev parent reply other threads:[~2023-07-21 16:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 16:16 [PATCHSET v5 0/9] Improve async iomap DIO performance Jens Axboe
2023-07-21 16:16 ` [PATCH 1/9] iomap: cleanup up iomap_dio_bio_end_io() Jens Axboe
2023-07-21 16:16 ` [PATCH 2/9] iomap: add IOMAP_DIO_INLINE_COMP Jens Axboe
2023-07-21 16:16 ` [PATCH 3/9] iomap: treat a write through cache the same as FUA Jens Axboe
2023-07-21 16:25 ` Darrick J. Wong
2023-07-21 16:27 ` Jens Axboe
2023-07-21 16:47 ` Darrick J. Wong
2023-07-21 16:52 ` Jens Axboe
2023-07-21 16:16 ` [PATCH 4/9] iomap: completed polled IO inline Jens Axboe
2023-07-21 16:16 ` [PATCH 5/9] iomap: only set iocb->private for polled bio Jens Axboe
2023-07-21 16:16 ` [PATCH 6/9] fs: add IOCB flags related to passing back dio completions Jens Axboe
2023-07-21 16:28 ` Darrick J. Wong
2023-07-21 16:30 ` Jens Axboe
2023-07-21 16:43 ` Jens Axboe [this message]
2023-07-21 16:16 ` [PATCH 7/9] io_uring/rw: add write support for IOCB_DIO_CALLER_COMP Jens Axboe
2023-07-21 16:29 ` Darrick J. Wong
2023-07-21 16:16 ` [PATCH 8/9] iomap: support IOCB_DIO_CALLER_COMP Jens Axboe
2023-07-21 16:16 ` [PATCH 9/9] iomap: use an unsigned type for IOMAP_DIO_* defines Jens Axboe
2023-07-21 16:29 ` Darrick J. Wong
2023-07-24 16:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox