From: Jens Axboe <[email protected]>
To: Helge Deller <[email protected]>,
John David Anglin <[email protected]>,
[email protected], [email protected],
James Bottomley <[email protected]>
Subject: Re: io_uring failure on parisc with VIPT caches
Date: Wed, 15 Feb 2023 09:04:36 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 2/15/23 9:02?AM, Helge Deller wrote:
>>>> +static unsigned long io_uring_mmu_get_unmapped_area(struct file *filp,
>>>> + unsigned long addr, unsigned long len,
>>>> + unsigned long pgoff, unsigned long flags)
>>>> +{
>>>> + const unsigned long mmap_end = arch_get_mmap_end(addr, len, flags);
>>>> + struct vm_unmapped_area_info info;
>>>> + void *ptr;
>>>> +
>>>> + ptr = io_uring_validate_mmap_request(filp, pgoff, len);
>>>> + if (IS_ERR(ptr))
>>>> + return -ENOMEM;
>>>> +
>>>> + /* we do not support requesting a specific address */
>>>> + if (addr)
>>>> + return -EINVAL;
>>>
>>> With this ^ we disallow users to provide a proposed address.
>>> I think this is ok and I suggest to keep it that way.
>>>
>>> Alternatively one could check the given address against the
>>> alignment which is calculated below, but this will make the
>>> code IMHO unnecessary bigger.
>>
>> liburing won't provide an address, so I'd say let's just keep it as-is.
>
> Good.
Maybe it'd be saner to add that alignment check? Just in case someone is
passing in an address already, we could just make it fail for SHMLBA !=
0 (or SHM_COLOUR, I'll leave that to you).
--
Jens Axboe
next prev parent reply other threads:[~2023-02-15 16:04 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 9:47 io_uring failure on parisc (32-bit userspace and 64-bit kernel) Helge Deller
2023-02-12 13:16 ` Jens Axboe
2023-02-12 13:28 ` Helge Deller
2023-02-12 13:35 ` Jens Axboe
2023-02-12 14:00 ` Jens Axboe
2023-02-12 14:03 ` Helge Deller
2023-02-12 19:35 ` Helge Deller
2023-02-12 19:42 ` Jens Axboe
2023-02-12 20:01 ` Helge Deller
2023-02-12 21:48 ` Jens Axboe
2023-02-12 22:20 ` Helge Deller
2023-02-12 22:31 ` Helge Deller
2023-02-13 16:15 ` Jens Axboe
2023-02-13 20:59 ` Helge Deller
2023-02-13 21:05 ` Jens Axboe
2023-02-13 22:05 ` Helge Deller
2023-02-13 22:50 ` John David Anglin
2023-02-14 23:09 ` io_uring failure on parisc with VIPT caches Helge Deller
2023-02-14 23:29 ` Jens Axboe
2023-02-15 2:12 ` John David Anglin
2023-02-15 15:16 ` Jens Axboe
2023-02-15 15:52 ` Helge Deller
2023-02-15 15:56 ` Jens Axboe
2023-02-15 16:02 ` Helge Deller
2023-02-15 16:04 ` Jens Axboe [this message]
2023-02-15 21:40 ` Helge Deller
2023-02-15 23:04 ` Jens Axboe
2023-02-15 16:38 ` John David Anglin
2023-02-15 17:01 ` Jens Axboe
2023-02-15 19:00 ` Jens Axboe
2023-02-15 19:16 ` Jens Axboe
2023-02-15 20:27 ` John David Anglin
2023-02-15 20:37 ` Jens Axboe
2023-02-15 21:06 ` John David Anglin
2023-02-15 21:38 ` Jens Axboe
2023-02-15 21:39 ` John David Anglin
2023-02-15 22:10 ` John David Anglin
2023-02-15 23:02 ` Jens Axboe
2023-02-15 23:43 ` John David Anglin
2023-02-16 2:40 ` John David Anglin
2023-02-16 2:50 ` Jens Axboe
2023-02-16 8:24 ` Helge Deller
2023-02-16 15:22 ` Jens Axboe
2023-02-16 20:35 ` John David Anglin
2023-02-15 23:03 ` Jens Axboe
2023-02-15 19:20 ` John David Anglin
2023-02-15 19:24 ` Jens Axboe
2023-02-15 16:18 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox