From: Jens Axboe <axboe@kernel.dk>
To: Haiyue Wang <haiyuewa@163.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH v1] selftests: io_uring/zcrx: Use PAGE_SIZE for ring refill alignment
Date: Sat, 19 Apr 2025 06:53:26 -0600 [thread overview]
Message-ID: <75a68330-96ce-49a8-bc63-519baa480710@kernel.dk> (raw)
In-Reply-To: <20250419095801.4162-1-haiyuewa@163.com>
On 4/19/25 3:57 AM, Haiyue Wang wrote:
> According to the 'Create refill ring' section in [1], use the macro
> PAGE_SIZE instead of 4096 hard code number.
>
> [1]: https://www.kernel.org/doc/html/latest/networking/iou-zcrx.html
Same here, should use a runtime query to get it. This is not like
in-kernel code where PAGE_SIZE can indeed be used.
--
Jens Axboe
prev parent reply other threads:[~2025-04-19 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 9:57 [PATCH v1] selftests: io_uring/zcrx: Use PAGE_SIZE for ring refill alignment Haiyue Wang
2025-04-19 12:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75a68330-96ce-49a8-bc63-519baa480710@kernel.dk \
--to=axboe@kernel.dk \
--cc=haiyuewa@163.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox