[PATCH v1] selftests: io_uring/zcrx: Use PAGE_SIZE for ring refill alignment

[PATCH v1] selftests: io_uring/zcrx: Use PAGE_SIZE for ring refill alignment

[Haiyue Wang]

According to the 'Create refill ring' section in [1], use the macro
PAGE_SIZE instead of 4096 hard code number.

[1]: https://www.kernel.org/doc/html/latest/networking/iou-zcrx.html

Signed-off-by: Haiyue Wang <haiyuewa@163.com>
---
 tools/testing/selftests/drivers/net/hw/iou-zcrx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
index c26b4180eddd..b9f6eb43400a 100644
--- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
+++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
@@ -115,7 +115,7 @@ static inline size_t get_refill_ring_size(unsigned int rq_entries)
 	ring_size = rq_entries * sizeof(struct io_uring_zcrx_rqe);
 	/* add space for the header (head/tail/etc.) */
 	ring_size += PAGE_SIZE;
-	return ALIGN_UP(ring_size, 4096);
+	return ALIGN_UP(ring_size, PAGE_SIZE);
 }
 
 static void setup_zcrx(struct io_uring *ring)
-- 
2.49.0

Re: [PATCH v1] selftests: io_uring/zcrx: Use PAGE_SIZE for ring refill alignment

[Jens Axboe]

On 4/19/25 3:57 AM, Haiyue Wang wrote:
> According to the 'Create refill ring' section in [1], use the macro
> PAGE_SIZE instead of 4096 hard code number.
> 
> [1]: https://www.kernel.org/doc/html/latest/networking/iou-zcrx.html

Same here, should use a runtime query to get it. This is not like
in-kernel code where PAGE_SIZE can indeed be used.

-- 
Jens Axboe