From: Jens Axboe <[email protected]>
To: Olivier Langlois <[email protected]>,
Randy Dunlap <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected], [email protected]
Subject: Re: [PATCH v2] io_uring: reduce latency by reissueing the operation
Date: Mon, 21 Jun 2021 10:03:22 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 6/20/21 1:28 PM, Olivier Langlois wrote:
> On Sun, 2021-06-20 at 12:07 -0700, Randy Dunlap wrote:
>> On 6/20/21 12:05 PM, Olivier Langlois wrote:
>>> - return false;
>>> + return ret?IO_ARM_POLL_READY:IO_ARM_POLL_ERR;
>>
>> Hi,
>> Please make that return expression more readable.
>>
>>
> How exactly?
>
> by adding spaces?
> Changing the define names??
Not super important, but I greatly prefer:
if (ret)
return IO_ARM_POLL_READY;
return IO_ARM_POLL_ERR;
as that's a lot more readable to me. This is orthogonal to the currently
missing spaces, of course.
For the defines, an enum would be preferable too. And place it near where
it's used.
--
Jens Axboe
next prev parent reply other threads:[~2021-06-21 16:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 19:05 [PATCH v2] io_uring: reduce latency by reissueing the operation Olivier Langlois
2021-06-20 19:07 ` Randy Dunlap
2021-06-20 19:28 ` Olivier Langlois
2021-06-20 20:01 ` Randy Dunlap
2021-06-20 20:08 ` Pavel Begunkov
2021-06-20 20:54 ` Olivier Langlois
2021-06-20 22:17 ` Randy Dunlap
2021-06-21 16:03 ` Jens Axboe [this message]
2021-06-20 19:56 ` Pavel Begunkov
2021-06-20 20:03 ` Pavel Begunkov
2021-06-20 20:56 ` Olivier Langlois
2021-06-20 21:05 ` Olivier Langlois
2021-06-20 21:09 ` Pavel Begunkov
2021-06-20 21:11 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox