From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Cc: Beld Zhang <[email protected]>
Subject: Re: [PATCH v2 1/1] io_uring: fix ltimeout unprep
Date: Wed, 20 Oct 2021 16:45:56 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 10/20/21 15:01, Jens Axboe wrote:
> On Wed, 20 Oct 2021 09:53:02 +0100, Pavel Begunkov wrote:
>> io_unprep_linked_timeout() is broken, first it needs to return back
>> REQ_F_ARM_LTIMEOUT, so the linked timeout is enqueued and disarmed. But
>> now we refcounted it, and linked timeouts may get not executed at all,
>> leaking a request.
>>
>> Just kill the unprep optimisation.
Jens, if the patches are not too deep, would also be lovely to
add reported-by to this and the other one.
Link: https://github.com/axboe/liburing/issues/460
Reported-by: Beld Zhang <[email protected]>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-10-20 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 8:53 [PATCH v2 1/1] io_uring: fix ltimeout unprep Pavel Begunkov
2021-10-20 14:01 ` Jens Axboe
2021-10-20 15:45 ` Pavel Begunkov [this message]
2021-10-20 15:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox