From: Jens Axboe <[email protected]>
To: Colin Ian King <[email protected]>
Cc: Alexander Viro <[email protected]>,
linux-fsdevel <[email protected]>,
[email protected],
"[email protected]" <[email protected]>
Subject: Re: io_uring: process task work in io_uring_register()
Date: Thu, 8 Oct 2020 19:09:41 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 10/8/20 12:23 PM, Colin Ian King wrote:
> Hi,
>
> Static analysis with Coverity has detected a "dead-code" issue with the
> following commit:
>
> commit af9c1a44f8dee7a958e07977f24ba40e3c770987
> Author: Jens Axboe <[email protected]>
> Date: Thu Sep 24 13:32:18 2020 -0600
>
> io_uring: process task work in io_uring_register()
>
> The analysis is as follows:
>
> 9513 do {
> 9514 ret =
> wait_for_completion_interruptible(&ctx->ref_comp);
>
> cond_const: Condition ret, taking false branch. Now the value of ret is
> equal to 0.
>
> 9515 if (!ret)
> 9516 break;
> 9517 if (io_run_task_work_sig() > 0)
> 9518 continue;
> 9519 } while (1);
> 9520
> 9521 mutex_lock(&ctx->uring_lock);
> 9522
>
> const: At condition ret, the value of ret must be equal to 0.
> dead_error_condition: The condition ret cannot be true.
Thanks, yeah that condition is reversed, should be:
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 4df5b14c2e56..80a0aa33db49 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -9511,8 +9511,8 @@ static int __io_uring_register(struct io_ring_ctx *ctx, unsigned opcode,
ret = wait_for_completion_interruptible(&ctx->ref_comp);
if (!ret)
break;
- if (io_run_task_work_sig() > 0)
- continue;
+ if (io_run_task_work_sig() <= 0)
+ break;
} while (1);
mutex_lock(&ctx->uring_lock);
--
Jens Axboe
prev parent reply other threads:[~2020-10-09 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 18:23 io_uring: process task work in io_uring_register() Colin Ian King
2020-10-08 19:13 ` Jann Horn
2020-10-08 19:14 ` Jann Horn
2020-10-09 1:09 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox