Re: [PATCH v2 0/4] clodkid and abs mode CQ wait timeouts

[Jens Axboe <axboe@kernel.dk>]

On 8/12/24 6:50 PM, Pavel Begunkov wrote:
> On 8/12/24 19:30, Jens Axboe wrote:
>> On 8/12/24 12:13 PM, Jens Axboe wrote:
>>> On 8/7/24 8:18 AM, Pavel Begunkov wrote:
>>>> Patch 3 allows the user to pass IORING_ENTER_ABS_TIMER while waiting
>>>> for completions, which makes the kernel to interpret the passed timespec
>>>> not as a relative time to wait but rather an absolute timeout.
>>>>
>>>> Patch 4 adds a way to set a clock id to use for CQ waiting.
>>>>
>>>> Tests: https://github.com/isilence/liburing.git abs-timeout
>>>
>>> Looks good to me - was going to ask about tests, but I see you have those
>>> already! Thanks.
>>
>> Took a look at the test, also looks good to me. But we need the man
>> pages updated, or nobody will ever know this thing exists.
> 
> If we go into that topic, people not so often read manuals
> to learn new features, a semi formal tutorial would be much
> more useful, I believe.
> 
> Regardless, I can update mans before sending the tests, I was
> waiting if anyone have feedback / opinions on the api.

I regularly get people sending corrections or questions after having
read man pages, so I'd have to disagree. In any case, if there's one
spot that SHOULD have the documentation, it's the man pages. Definitely
any addition should be added there too.

I'd love for the man pages to have more section 7 additions, like one on
fixed buffers and things like that, so that it would be THE spot to get
to know about these features. Tutorials always useful (even if they tend
often age poorly), but that should be an addition to the man pages, not
instead of. On the GH wiki is where they can go, and I believe you have
write access there too :-)

-- 
Jens Axboe