From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 630252500B1 for ; Fri, 21 Feb 2025 17:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740158940; cv=none; b=jXq3/VbOH87Mcw0D+5O7rmwng1BSsBr2DanektJmebyH14DN6FKnhmiLX9PEVuse327+G9tOSi5suedr1ze7D6VZlKePgIswqi0HQJ0rMuG5iepsrZnPfos+0VxUz0g7tOD8435xvsaEAKL5siWZjcEDjzqTBSEgHNs1+dpEYQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740158940; c=relaxed/simple; bh=ssnP7xR5IX0s1ZnFseYvUfkt85pqBiRp2h4Q4S5mkyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VXBNWSBiC0MIfAXBVTvPtmza7Es9bXWWlIcHqLoRm8g5Cx9YAVm7aBdFOsnZhoImFIqB9jQ0I+4E661dF4i7Js1GJYND9oiMC+PRhZxK+b0608xELnrjLTLE9OfE6xAFs9f0RmrBF4qQZX5sIM2TdqOL/NAwO9S1VszTnD0XF+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=S97xNopL; arc=none smtp.client-ip=209.85.166.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="S97xNopL" Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-3ce915a8a25so7001395ab.1 for ; Fri, 21 Feb 2025 09:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1740158937; x=1740763737; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NDZTfHmSgit6Hdb4LSC2+LwR3rhMNBxY6UI+uK+57J4=; b=S97xNopLG5OylwEM7sDy5EQavgtOf+MayQx9bnWjpArBWh3mp4EzY3Ef8X3nBfY1we 3bwqKwCDMiErQeyihY6Bsm74VFfNAKPZienADefq/ObKYtEqymoWBZ2HMVdqLGyhzRIf YZqTGLKUg8sKR/ynQUL+QLbbKvhBr6+YvRR3BGoc6kMaL3cgA1VCienKbW2raHo2IBXA d3Ip7Uku46zFbuj3JtIruCf1N6eS/zvLdgkmcN9zc9+pUhV+ScICNER/NypUUha0gjlF KCVk2W99bX+ce0rS+AL7zADTbkWX6EyDubqLWx7eSCLRBmoPx18v15kgJhLqb08detDO V6NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740158937; x=1740763737; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NDZTfHmSgit6Hdb4LSC2+LwR3rhMNBxY6UI+uK+57J4=; b=W7zrrVjrTwsmXAtSzbU/cgcbfSAxEh/J8HiTZY43TijTG26r0beiExbJA3Fqxd/JOn nPnpARPStFXOmtXfYnzxE0Qz3koWF5EFbQLyQYQR9Og7RBgLJPVcl3qjXOO9sudW1hAa AHriXCvWTXFC1X6g0tt4x5hQR0zPWg8s+T84yuOFNjbj+1oruOUZHP96jjxxnjAAfJCw eunJjOnxbGGQ0H+gRvX6icSs8vAL2i8+Uu5k2Sx182lF+iiyNoWoWpZr9tdc+UWpuU5q B1eD+f+spPSAZkBRHpU0r+baF673otwpoCwc3htLE27C8WwK86QTU8D3dqmrnFtw35Fd CSaQ== X-Forwarded-Encrypted: i=1; AJvYcCVgU3vbceUIvoq1YOCQFVOn4fA8PPLSstFXLsrWMtROBts0NDuRch/pMaguCLnvI+mJgJd6nJNHBQ==@vger.kernel.org X-Gm-Message-State: AOJu0YzlehqrWK6oKbDsE1qE/1cXbX4y00XLwyrFagqU9/B7z1SXFbmY QaXQcaq4/FFHsCkV0yH8RpxRzkBRQ+YRqb39cqGOgo9Duodz6Jyyg42cfhDTgHg= X-Gm-Gg: ASbGncuK8M410cV0pdoq03GNd9hj2m16yJ4fS88NULZneBuO0yvtNtmeim0GMMd9AVr iMRYrFs+82g7HX6j85ZxXbeMUMqvdwFLg9SSAGS1tigmK8eg02svASbq3CfEeVHL2Esxs87DzNC qKODrGE1glzXnV00gwDmgmR3pbJ2g5CXQCIKTJ6XVdmYK2tfIKs9RhWNiA6JEsybPodkTcC5yh7 +QQ0rhiZCCkr6OesTVZB2toA/gBeFnTZEbCLFIIwPiKE5VJodKSDTzPvFNd05xPRTWGOnHBGycz EQmtK6pBQNa0wMfTgpjqkeM= X-Google-Smtp-Source: AGHT+IESXRf1yl6h7PyEHQmBUGrv9XVl2XmLwA/QxwaTFWH5Y02ORzR6Hbof0RMkoUqPvVurTqR6Jg== X-Received: by 2002:a05:6e02:1a2a:b0:3d2:6768:c4fa with SMTP id e9e14a558f8ab-3d2caf0980emr47338065ab.21.1740158937487; Fri, 21 Feb 2025 09:28:57 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ee93efe46csm2701099173.132.2025.02.21.09.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2025 09:28:56 -0800 (PST) Message-ID: <7980bc81-8077-4c99-88e4-19188745d3a2@kernel.dk> Date: Fri, 21 Feb 2025 10:28:56 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in io_uring_mmap To: Pavel Begunkov , lizetao , Bui Quang Minh Cc: David Wei , "linux-kernel@vger.kernel.org" , "io-uring@vger.kernel.org" References: <20250221085933.26034-1-minhquangbui99@gmail.com> <590cff7ccda34b028706b9288f8928d3@huawei.com> <79189960-b645-4b51-a3d7-609708dc3ee2@gmail.com> <0c1faa58-b658-4a64-9d42-eaf603fdc69d@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/21/25 10:06 AM, Pavel Begunkov wrote: > On 2/21/25 16:39, Jens Axboe wrote: >> On 2/21/25 5:20 AM, Pavel Begunkov wrote: >>> On 2/21/25 09:10, lizetao wrote: >>>> Hi, >>>> >>>>> -----Original Message----- >>>>> From: Bui Quang Minh >>>>> Sent: Friday, February 21, 2025 5:00 PM >>>>> To: io-uring@vger.kernel.org >>>>> Cc: Jens Axboe ; Pavel Begunkov >>>>> ; David Wei ; linux- >>>>> kernel@vger.kernel.org; Bui Quang Minh >>>>> Subject: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in >>>>> io_uring_mmap >>>>> >>>>> Allow user to mmap the kernel allocated zerocopy-rx refill queue. >>>>> >>>> >>>> Maybe fixed-tag should be added here. >>> >>> No need, it's not strictly a fix, and whlist it's not yet sent to >>> linus, the tags only cause confusion when hashes change, e.g. on rebase. >> >> I do like using fixes still, if only to provide a link to the original >> commit without needing to dig for it. And yeah there's the occasional >> rebase where I forget to update the sha, but those get discovered pretty >> quick. > > Maybe a "Link" tag would be better or some more inconsequential > "Refers-to", but otherwise you can call it a feature and avoid the > hassle of fixing it up, and people getting spammed by tooling, > and Stephen having to write about broken hashes. Having the sha is nice though so people can just look it up. But yeah the tag doesn't really exist, and I think we have way too many tags already, which is why I just use Fixes for stuff like that too. Link is good for email discussion, though 99% of the time it ends up just being a patch posting and not really interesting... -- Jens Axboe