public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Joseph Qi <[email protected]>,
	Xiaoguang Wang <[email protected]>,
	Pavel Begunkov <[email protected]>,
	io-uring <[email protected]>,
	Hao Xu <[email protected]>
Subject: Re: [ANNOUNCEMENT] io_uring SQPOLL sharing changes
Date: Tue, 23 Mar 2021 10:22:48 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 3/22/21 10:09 PM, Joseph Qi wrote:
> 
> 
> On 3/22/21 10:49 PM, Jens Axboe wrote:
>> On 3/21/21 11:54 PM, Xiaoguang Wang wrote:
>>> hi Pavel,
>>>
>>>> Hey,
>>>>
>>>> You may have already noticed, but there will be a change how SQPOLL
>>>> is shared in 5.12. In particular, SQPOLL may be shared only by processes
>>>> belonging to the same thread group. If this condition is not fulfilled,
>>>> then it silently creates a new SQPOLL task.
>>>
>>> Thanks for your kindly reminder, currently we only share sqpoll thread
>>> in threads belonging to one same process.
>>
>> That's good to know, imho it is also the only thing that _really_ makes
>> sense to do.
>>
>> Since we're on the topic, are you actively using the percpu thread setup
>> that you sent out patches for earlier? That could still work within
>> the new scheme of having io threads, but I'd be curious to know first
>> if you guys are actually using it.
>>
> 
> Yes, we've already used percpu sqthread feature in our production
> environment, in which 16 application threads share the same sqthread,
> and it gains ~20% rt improvement compared with libaio.

Great! Any chance I can get you to re-post the patches against the
current tree?

-- 
Jens Axboe


  reply	other threads:[~2021-03-23 16:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 15:48 [ANNOUNCEMENT] io_uring SQPOLL sharing changes Pavel Begunkov
2021-03-22  5:54 ` Xiaoguang Wang
2021-03-22 14:49   ` Jens Axboe
2021-03-23  4:09     ` Joseph Qi
2021-03-23 16:22       ` Jens Axboe [this message]
2021-03-24  2:14         ` Joseph Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox