From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99CEE73165 for ; Thu, 14 Mar 2024 16:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710432167; cv=none; b=RmcPVGpYBfSLRkyweO9l1OhoBipZGW/Ro1T53OOduSBKRpE9Zn5Q4i6v+HIAAHC+ZBuz+rGu971Aq/2uRQd6TYqhAWO3jIL4JdE5DO5mk/HCmKsePEorqD+h+9jDdI37JCJ724McyifbS9b5oC+ffNmfXAEPd6Mfl5juLZdmk7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710432167; c=relaxed/simple; bh=yPIgt4zoNub9ymm4btsAb/8Wg/W9ZfsIoFT2aUWIRVs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a25P54jmTdNo8paNeMkFu17uyeY6+XT6MApI6ePh+Aun+hdwXH2lkw+xyZTi2BSvOhdOXdjp86Fmp33a9BrZPBLXsyCqAwmE+qKMfb0l2kOFQDolQcfUUZ3ebSQkoFUnV2e3seFLi9BGT8e9jHA3m3PNrBvAqMxh85OFPbrgDg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=cCMj+ER0; arc=none smtp.client-ip=209.85.166.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="cCMj+ER0" Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-366478a02baso1965905ab.0 for ; Thu, 14 Mar 2024 09:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1710432165; x=1711036965; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aMYe/+wuIMRrzJVkoVVY+zCmShtZ6kBSGstMUDAkBRg=; b=cCMj+ER0/3GYlBKCLNANcR9SWcGJuSt/yBEMlHUnkybmV/ozXajBE7jgaMsKup7N4/ C41nAHQKjGLng/ERxX0bAa2ZYmJiT4W6V7Ln0m8UjkOOWmiqSXysjKZePWZqvz0L4U8c 9h38GF589mPwENWJNRDWpeSE4bt1/xi1X2mQYq5j9AGLhrggor9tynqzvx51FBz+oJhW a/aDFNOFCUQA7QKmFCw5Irjxy4Y2XvofFOBaMQFlcOm7LO5dJcJfV7DajaVb1Arcj2oC ciOJYYvzq0xbgseUqc/5kOqC7FiOltQsYtkDM+7EaYZ4mklz27C17uuAauIy6wJQJqcf yHwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710432165; x=1711036965; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aMYe/+wuIMRrzJVkoVVY+zCmShtZ6kBSGstMUDAkBRg=; b=jRF0Q9S1IcmoC0qiBIPu6MPpfIBRDY3LfWnJ9g/o1jxjPmxE691rxeEF7GmRZDWeup vdAk+huaUM3JUqNiKtljCYp8iuTIrmmAJGrgZBfTfy0yaGFt97v7CV65S1he4OGfmQl6 Nv0zMG5fKMmNrHYwJm+zL07bTpF4NdAczNEp+lYAsAP6fmT4Wvo6wcC9nNL+hta3M8Rf S+/Ks1715huMLRUqBk4blwUobNoCisggA3EknvSiubL7YN9+Z11890RIZ+R/8zSNqNL8 84gYuPGvbGiwedPxVbJeWqzRk1HN6wQYMMuxcwNSRzIfEJkQewg/bu5z0/cAwHSU+fmm TpNQ== X-Forwarded-Encrypted: i=1; AJvYcCWXy/wvzKA61dc8zdLiFW/Vbjo8xJCTKe46e6+TKouVbmqFe4MApdVY0jLKSgI6o5SNU8wBMlBovfGmiaUEI8f/2WQI0PGSI1M= X-Gm-Message-State: AOJu0Yy6OR90ygJTRiQfsN7dU7FmwO1+azNw5AFh8+VN2yFntdTOXL4I O10q96sYWPn7n0GiVt3shBMYXJHWRDBEtFTI79aRqe4vwi2dLb8O9BH+yUW+C6A= X-Google-Smtp-Source: AGHT+IE04Rlqombq5HbsU6MQJnA1CY+nLOcuKvmSdWD0vbchEpHxzVEbpGlZkHj+eyglBvArxb1PDA== X-Received: by 2002:a5e:c90e:0:b0:7c8:afe9:b1eb with SMTP id z14-20020a5ec90e000000b007c8afe9b1ebmr2505802iol.1.1710432164535; Thu, 14 Mar 2024 09:02:44 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id hh13-20020a0566021d0d00b007c8b1ace770sm416463iob.39.2024.03.14.09.02.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 09:02:44 -0700 (PDT) Message-ID: <7ac9f1f3-9551-473e-b3ab-329e276aa41f@kernel.dk> Date: Thu, 14 Mar 2024 10:02:43 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5.10/5.15] io_uring: fix registered files leak Content-Language: en-US To: Fedor Pchelkin Cc: Pavel Begunkov , Greg Kroah-Hartman , stable@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org, Nikita Zhandarovich , Roman Belyaev References: <20240312142313.3436-1-pchelkin@ispras.ru> <8a9993c7-fd4d-44ff-8971-af59c7f3052c@kernel.dk> <466e842f-66c6-4530-8c16-2b008fc3fbc6-pchelkin@ispras.ru> <085beb85-d1a4-4cb0-969b-e0f895a95738@kernel.dk> <3f17f1d9-9029-4d03-9b0a-9c500cce54e9@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/14/24 9:55 AM, Fedor Pchelkin wrote: > On 24/03/13 06:40PM, Jens Axboe wrote: >> Hi, >> >> OK, here they are. Two patches attached for every stable kernel, that >> gets rid of the remnants of the SCM related code: >> >> 5.4 >> 5.10 and 5.15 (same patches) >> 6.1 >> 6.6 >> 6.7 >> >> Would appreciate if Fedor and Pavel could give them a once over, but I >> think they are all fine. It's just deleting the code... > > Thank you, Jens! > > FWIW, I think it's all good and it eliminates the reported problem > obviously. Compiled and tested the repro with my kernel config. Great, thanks for checking! > Just a minor notice - stable rules declare two common ways for upstream > patch mentioning in backports [1]. And the first one starts from > lowercase. No big deal here definitely but maybe somebody has some > handling of these two variants - by regexps or similar, I actually don't > know. But I see in the git history that Greg also applies the variant > you've used. Honestly that doesn't matter, as long as the upstream commit is referenced. I always do it this way, not my first stable rodeo. -- Jens Axboe