From: Pavel Begunkov <[email protected]>
To: [email protected]
Cc: Jens Axboe <[email protected]>, [email protected]
Subject: [PATCH for-next 3/7] io_uring/net: preset notif tw handler
Date: Fri, 4 Nov 2022 10:59:42 +0000 [thread overview]
Message-ID: <7acdbea5e20eadd844513320cd454af14ba50f64.1667557923.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>
We're going to have multiple notification tw functions. In preparation
for future changes default the tw callback in advance so later we can
replace it with other versions.
Signed-off-by: Pavel Begunkov <[email protected]>
---
io_uring/notif.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/io_uring/notif.c b/io_uring/notif.c
index 59dafc42b8e0..6afb58b94297 100644
--- a/io_uring/notif.c
+++ b/io_uring/notif.c
@@ -39,10 +39,8 @@ static void io_uring_tx_zerocopy_callback(struct sk_buff *skb,
WRITE_ONCE(nd->zc_copied, true);
}
- if (refcount_dec_and_test(&uarg->refcnt)) {
- notif->io_task_work.func = __io_notif_complete_tw;
+ if (refcount_dec_and_test(&uarg->refcnt))
io_req_task_work_add(notif);
- }
}
struct io_kiocb *io_alloc_notif(struct io_ring_ctx *ctx)
@@ -60,6 +58,7 @@ struct io_kiocb *io_alloc_notif(struct io_ring_ctx *ctx)
notif->task = current;
io_get_task_refs(1);
notif->rsrc_node = NULL;
+ notif->io_task_work.func = __io_notif_complete_tw;
nd = io_notif_to_data(notif);
nd->account_pages = 0;
@@ -76,8 +75,6 @@ void io_notif_flush(struct io_kiocb *notif)
struct io_notif_data *nd = io_notif_to_data(notif);
/* drop slot's master ref */
- if (refcount_dec_and_test(&nd->uarg.refcnt)) {
- notif->io_task_work.func = __io_notif_complete_tw;
+ if (refcount_dec_and_test(&nd->uarg.refcnt))
io_req_task_work_add(notif);
- }
}
--
2.38.0
next prev parent reply other threads:[~2022-11-04 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 10:59 [PATCH for-next 0/7] small zc improvements Pavel Begunkov
2022-11-04 10:59 ` [PATCH for-next 1/7] io_uring: move kbuf put out of generic tw complete Pavel Begunkov
2022-11-04 10:59 ` [PATCH for-next 2/7] io_uring/net: remove extra notif rsrc setup Pavel Begunkov
2022-11-04 10:59 ` Pavel Begunkov [this message]
2022-11-04 10:59 ` [PATCH for-next 4/7] io_uring/net: rename io_uring_tx_zerocopy_callback Pavel Begunkov
2022-11-04 10:59 ` [PATCH for-next 5/7] io_uring/net: inline io_notif_flush() Pavel Begunkov
2022-11-04 10:59 ` [PATCH for-next 6/7] io_uring: move zc reporting from the hot path Pavel Begunkov
2022-11-04 10:59 ` [PATCH for-next 7/7] io_uring/net: move mm accounting to a slower path Pavel Begunkov
2022-11-05 15:20 ` [PATCH for-next 0/7] small zc improvements Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7acdbea5e20eadd844513320cd454af14ba50f64.1667557923.git.asml.silence@gmail.com \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox