From: Jens Axboe <[email protected]>
To: Jackie Liu <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] io_uring: fix race with shadow drain deferrals
Date: Wed, 20 Nov 2019 16:14:52 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 11/20/19 6:57 PM, Jackie Liu wrote:
>> @@ -2957,15 +2975,14 @@ static void io_queue_sqe(struct io_kiocb *req)
>> int ret;
>>
>> ret = io_req_defer(req);
>> - if (ret) {
>> - if (ret != -EIOCBQUEUED) {
>> - io_cqring_add_event(req, ret);
>> - if (req->flags & REQ_F_LINK)
>> - req->flags |= REQ_F_FAIL_LINK;
>> - io_double_put_req(req);
>> - }
>> - } else
>> + if (!ret) {
>> __io_queue_sqe(req);
>> + } else if (ret != -EIOCBQUEUED) {
>> + io_cqring_add_event(req, ret);
>> + if (req->flags & REQ_F_LINK)
>> + req->flags |= REQ_F_FAIL_LINK;
>> + io_double_put_req(req);
>> + }
>> }
>
> Hmm.. Why we need rewrite there? clear code? Seems to be unrelated to
> this issue.
We don't need to, and the previous patch touched it, but it's much
easier to read after this change. Before it was:
if (ret) {
if (ret != -EIOCBQUEUED) {
...
}
} else {
...
}
which is now just
if (!ret) {
...
} else if (ret != -EIOCBQUEUED) {
...
}
not related to the change really, but kind of silly to make a separate
patch for imho.
--
Jens Axboe
next prev parent reply other threads:[~2019-11-21 2:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 23:07 [PATCH] io_uring: fix race with shadow drain deferrals Jens Axboe
2019-11-20 23:58 ` Jens Axboe
2019-11-21 1:32 ` Jackie Liu
2019-11-21 1:35 ` Jackie Liu
2019-11-21 1:40 ` Jens Axboe
2019-11-21 1:49 ` Jens Axboe
2019-11-21 1:57 ` Jackie Liu
2019-11-20 23:14 ` Jens Axboe [this message]
[not found] ` <[email protected]>
2019-11-20 23:03 ` Jens Axboe
2019-11-21 8:54 ` [PATCH] io_uring: drain next sqe instead of shadowing Pavel Begunkov
[not found] ` <[email protected]>
2019-11-21 9:43 ` Pavel Begunkov
[not found] ` <[email protected]>
2019-11-21 12:40 ` Pavel Begunkov
[not found] ` <[email protected]>
2019-11-21 13:47 ` Jens Axboe
[not found] ` <[email protected]>
2019-11-21 13:54 ` Jens Axboe
[not found] ` <[email protected]>
2019-11-21 14:28 ` Pavel Begunkov
2019-11-21 13:53 ` Jens Axboe
2019-11-21 15:23 ` Pavel Begunkov
2019-11-21 13:50 ` Jens Axboe
2019-11-21 1:39 ` [PATCH] io_uring: fix race with shadow drain deferrals Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox