public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [PATCH 0/4] address some hangs
Date: Thu, 31 Dec 2020 16:40:26 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 31/12/2020 15:07, Jens Axboe wrote:
> On 12/30/20 2:34 PM, Pavel Begunkov wrote:
>> 1/4 and 2/4 are for hangs during files unregister.
>>
>> The other two fix not running task works during cancellation.
>> Instead of patching task_work it moves io_uring_files_cancel()
>> before PF_EXITING, should be less intrusive. Was there a
>> particular reasong for doing that in exit_files()?
>>
>> Pavel Begunkov (4):
>>   io_uring: add a helper for setting a ref node
>>   io_uring: fix io_sqe_files_unregister() hangs
>>   kernel/io_uring: cancel io_uring before task works
>>   io_uring: cancel requests enqueued as task_work's
>>
>>  fs/file.c     |  2 --
>>  fs/io_uring.c | 54 ++++++++++++++++++++++++++++++++++-----------------
>>  kernel/exit.c |  2 ++
>>  3 files changed, 38 insertions(+), 20 deletions(-)
> 
> Applied 1-3, as they look good. Can you resend 4/4 with the return
> added?

1-3 should fix the problems, so let's put off 4 for later and not
for current.

-- 
Pavel Begunkov

      reply	other threads:[~2020-12-31 16:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30 21:34 [PATCH 0/4] address some hangs Pavel Begunkov
2020-12-30 21:34 ` [PATCH 1/4] io_uring: add a helper for setting a ref node Pavel Begunkov
2020-12-30 21:34 ` [PATCH 2/4] io_uring: fix io_sqe_files_unregister() hangs Pavel Begunkov
2020-12-30 21:34 ` [PATCH 3/4] kernel/io_uring: cancel io_uring before task works Pavel Begunkov
2021-01-02 16:01   ` Pavel Begunkov
2020-12-30 21:34 ` [PATCH 4/4] io_uring: cancel requests enqueued as task_work's Pavel Begunkov
2020-12-31 15:06   ` Jens Axboe
2020-12-31 15:07 ` [PATCH 0/4] address some hangs Jens Axboe
2020-12-31 16:40   ` Pavel Begunkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox