public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Christoph Hellwig <[email protected]>
Cc: [email protected], Jens Axboe <[email protected]>,
	[email protected], [email protected],
	Conrad Meyer <[email protected]>
Subject: Re: [PATCH v5 5/8] block: implement async io_uring discard cmd
Date: Thu, 12 Sep 2024 17:19:49 +0100	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 9/12/24 10:31, Christoph Hellwig wrote:
>> + * io_uring block file commands, see IORING_OP_URING_CMD.
>> + * It's a different number space from ioctl(), reuse the block's code 0x12.
>> + */
>> +#define BLOCK_URING_CMD_DISCARD			_IO(0x12, 0)
> 
> Please just start out at some arbitrary boundary, but don't reuse
> the ioctl code from an ioctl that does something vaguely similar for
> no good reason.

It's a entirely different number space, it shouldn't care about
ioctl numbering. Regardless, BLK* in fs.h start with 93. I don't
even have a clue where is the rest.

Code  Seq#    Include File                           Comments
0x12  all    linux/fs.h                              BLK* ioctls
              linux/blkpg.h

-- 
Pavel Begunkov

  reply	other threads:[~2024-09-12 16:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11 16:34 [PATCH v5 0/8] implement async block discards and other ops via io_uring Pavel Begunkov
2024-09-11 16:34 ` [PATCH v5 1/8] io_uring/cmd: expose iowq to cmds Pavel Begunkov
2024-09-11 16:34 ` [PATCH v5 2/8] io_uring/cmd: give inline space in request " Pavel Begunkov
2024-09-11 16:34 ` [PATCH v5 3/8] filemap: introduce filemap_invalidate_pages Pavel Begunkov
2024-09-11 16:34 ` [PATCH v5 4/8] block: introduce blk_validate_byte_range() Pavel Begunkov
2024-09-12  9:29   ` Christoph Hellwig
2024-09-11 16:34 ` [PATCH v5 5/8] block: implement async io_uring discard cmd Pavel Begunkov
2024-09-12  9:31   ` Christoph Hellwig
2024-09-12 16:19     ` Pavel Begunkov [this message]
2024-09-11 16:34 ` [PATCH v5 6/8] block: implement write zeroes io_uring cmd Pavel Begunkov
2024-09-12  9:32   ` Christoph Hellwig
2024-09-12 16:25     ` Pavel Begunkov
2024-09-12 16:32       ` Jens Axboe
2024-09-12 16:53         ` Pavel Begunkov
2024-09-12 16:59           ` Jens Axboe
2024-09-13  7:45         ` Christoph Hellwig
2024-09-11 16:34 ` [PATCH v5 7/8] block: add nowait flag for __blkdev_issue_zero_pages Pavel Begunkov
2024-09-11 16:34 ` [PATCH v5 8/8] block: implement write zero pages cmd Pavel Begunkov
2024-09-11 20:56 ` [PATCH v5 0/8] implement async block discards and other ops via io_uring Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox