From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2079C33CA9 for ; Mon, 13 Jan 2020 16:58:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B77BF2075B for ; Mon, 13 Jan 2020 16:58:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="eRQXTp5+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728674AbgAMQ6M (ORCPT ); Mon, 13 Jan 2020 11:58:12 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:35084 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727331AbgAMQ6M (ORCPT ); Mon, 13 Jan 2020 11:58:12 -0500 Received: by mail-io1-f66.google.com with SMTP id h8so10583373iob.2 for ; Mon, 13 Jan 2020 08:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n2qCWY9dDm8azp3DnmT/BcaCngFCq3W2JQHBtzBAlYY=; b=eRQXTp5+Fdsol+TwBhKVu36c+xEsubHFLEjWy9QFVzU1tB6qIF8pVl20WHhmQVxRFC yZMw4hZJpVz1PjtQbwHArQY38aNPdjVMS3CXL+JfvCw7iXwiZ41JMzuSjtpp7/RSUv25 9vlS42r4EFT/QDwNGKJ9WLEgRuxUvroVRjD/tG9aHzVZVjzbZqEwyTm8LfqfyT6550Zd Al1MTC1QA2+JfmQQPqAHN/SHpOfgI1HXxP75fLNYbB+zSYPRRxqY7ACrh3Xj70tA6lQN Ef7nr8UozdVnu1wEdVOFSmQhtZVQqz9o36szU/uaAKGdLLb9jDo4OgzDl2FRFVJk8rU1 4/Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n2qCWY9dDm8azp3DnmT/BcaCngFCq3W2JQHBtzBAlYY=; b=WOrh2kJ3H8srvmH7isKjL3EHUYYc0Fd24ywmLcwX3+ILtC1FtY+r++o6xe4m60TNC2 X5DiLa5etdrVWaW5xDdxI+1LWNWtsVjd7KcrAtDO3+/p0DgAxHVt7wXfqmv9VfSfcRo5 M43hev2yHEWVCzS1SPTP7YFvd4dA3Sj2TrH1LQzkAjZnqqTylK9aciXxqDO5BOihpkAJ 2dDzAa+H3nXgQf0pw9mzgyAQNZCSSNYbmY5L2kh/5r+PLr/u6tY3DrqcXLhTz0OfNZOE HaD7nV5VbyDajmmVAcSfdbck3bfmF7LZKlI7/Tm2RZRmCBbpJTzQ0NoTkYw8o2lDHGc1 3FGQ== X-Gm-Message-State: APjAAAUF/YfLaHGibQQCqUqN4zHj+3dO1OtqdZ1l61hD8wZplilppHxV DL/Rby1FE4GoJqRPTTkof5Pr6x0A0WM= X-Google-Smtp-Source: APXvYqwyrhFsN2dBByOa3+7fTRrG+lp40kkZ9OndzVXmXHA7PqNVLg5aZ5lupvygNfFAdzHsiBTTaQ== X-Received: by 2002:a5e:920a:: with SMTP id y10mr13634213iop.292.1578934691437; Mon, 13 Jan 2020 08:58:11 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id m24sm2875133ioc.37.2020.01.13.08.58.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2020 08:58:10 -0800 (PST) Subject: Re: [PATCH 3/3] io_uring: add IORING_OP_MADVISE To: Pavel Begunkov , io-uring@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20200110154739.2119-1-axboe@kernel.dk> <20200110154739.2119-4-axboe@kernel.dk> From: Jens Axboe Message-ID: <7bf2e663-eb82-d8d5-304b-d06e183de235@kernel.dk> Date: Mon, 13 Jan 2020 09:58:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 1/12/20 2:39 PM, Pavel Begunkov wrote: > On 10/01/2020 18:47, Jens Axboe wrote: >> This adds support for doing madvise(2) through io_uring. We assume that >> any operation can block, and hence punt everything async. This could be >> improved, but hard to make bullet proof. The async punt ensures it's >> safe. >> > I don't like that it share structs/fields names with fadvise. E.g. madvise's > context is called struct io_fadvise. Could it at least have fadvise_advice filed > in struct io_uring_sqe? io_uring parts of the patchset look good. > > Reviewed-by: Pavel Begunkov Thanks, I can add the separate union, not a big deal. -- Jens Axboe