From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA08C433EF for ; Tue, 31 May 2022 09:07:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245071AbiEaJHY (ORCPT ); Tue, 31 May 2022 05:07:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245103AbiEaJHR (ORCPT ); Tue, 31 May 2022 05:07:17 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6DBB24948 for ; Tue, 31 May 2022 02:07:13 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id x17so8686303wrg.6 for ; Tue, 31 May 2022 02:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Da7CpUzfigAT4CIYpAa4S3dnkp2cNQHn7AtCXpqTizs=; b=lIHzKa+jSnfytsD+Mp7xDDDZi7o4cUhwyisi0ts+8d3JRUbjVIV38DYCJHOl8pq2ib UB6/+hbLc2Sy2SYynmoqY/YWspccNUcJhI3/Sr2/+C9rg4S+digPGeenGn/SlFQCtKTd Gv8Jb+u/6n3HRS+vVcBKXeNKB2B40wlgPmWTbJqat3UipFJjX4oQmjTNENDYcMOvWUoT Eps+CWDrirAYSy07eTbSUzozxFjnoTuWQ/RyWsrs3m2UCCUU29fSVVaiJfWmtkAL/bUq Km2FcwbmPjMSMDx2wv+6XivFP7x6QJGHUYpyBcr4ouSR3yHAjaFL0T/YPnPy47UxTgIY jJlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Da7CpUzfigAT4CIYpAa4S3dnkp2cNQHn7AtCXpqTizs=; b=KM3mfhTADMRCz72h3UNmNtQir5ti6jrxJtOh7YjnPdfUUQRY/0GZUdOm2usM9ZE1C/ 3cKIyO26u5Tix796Vs8E7XebqcbU77F8daag2YO9MUL3PYr9YwNJQBZPI10cKdwOTiY7 YBxt2VuOhDimnqrjcH8HQXURyUHYdHchzYOKKTMLvwfes7jGN1tTaOmHX6fXdd/EYpa4 PFHxuuxoFazKwm1eqCb2n6TaXaegLDvyBo83NVzv1hdTsL0jFqusUs9nZsxftrQ7Yq2v OlYlYoHnYKGw52h/MQeeXq00DQG2yXeRM1N3v2Lfv5mMGlhWZtEwkn5xMZRg7BXWlROE wqyw== X-Gm-Message-State: AOAM532qItMtAo+78drYZVXfefhkLWxeVZ9oBzBKTdmJHlGG9q3pH5Eo gTwtf43oVsh1Ch9eurotAP8GCQ== X-Google-Smtp-Source: ABdhPJynCOtAl39IHyypdJg+WREtGlQuCJn0fX9jFpVVRkxUzkTM3i4oHVsc21wrbJlrvrSbtW7hUg== X-Received: by 2002:a5d:4fc2:0:b0:210:940:b1fd with SMTP id h2-20020a5d4fc2000000b002100940b1fdmr21151584wrw.134.1653988031891; Tue, 31 May 2022 02:07:11 -0700 (PDT) Received: from [10.188.163.71] (cust-east-parth2-46-193-73-98.wb.wifirst.net. [46.193.73.98]) by smtp.gmail.com with ESMTPSA id m10-20020a7bcb8a000000b00397243d3dbcsm1545690wmi.31.2022.05.31.02.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 02:07:11 -0700 (PDT) Message-ID: <7c582099-0eef-6689-203a-606cb2f69391@kernel.dk> Date: Tue, 31 May 2022 03:07:10 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [syzbot] UBSAN: array-index-out-of-bounds in io_submit_sqes Content-Language: en-US To: Dmitry Vyukov Cc: Hao Xu , syzbot , asml.silence@gmail.com, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <000000000000f0b26205e04a183b@google.com> <3d3c6b5f-84cd-cb25-812e-dac77e02ddbf@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 5/31/22 3:05 AM, Dmitry Vyukov wrote: > On Tue, 31 May 2022 at 11:01, Jens Axboe wrote: >> >> On 5/31/22 3:00 AM, Hao Xu wrote: >>> On 5/31/22 16:45, Jens Axboe wrote: >>>> On 5/31/22 1:55 AM, syzbot wrote: >>>>> Hello, >>>>> >>>>> syzbot found the following issue on: >>>>> >>>>> HEAD commit: 3b46e4e44180 Add linux-next specific files for 20220531 >>>>> git tree: linux-next >>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=16e151f5f00000 >>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=ccb8d66fc9489ef >>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=b6c9b65b6753d333d833 >>>>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 >>>>> >>>>> Unfortunately, I don't have any reproducer for this issue yet. >>>>> >>>>> IMPORTANT: if you fix the issue, please add the following tag to the commit: >>>>> Reported-by: syzbot+b6c9b65b6753d333d833@syzkaller.appspotmail.com >>>>> >>>>> ================================================================================ >>>>> ================================================================================ >>>>> UBSAN: array-index-out-of-bounds in fs/io_uring.c:8860:19 >>>>> index 75 is out of range for type 'io_op_def [47]' >>>> >>>> 'def' is just set here, it's not actually used after 'opcode' has been >>>> verified. >>>> >>> >>> Maybe we can move it to be below the opcode check to comfort UBSAN. >> >> Yeah that's what I did, just rebased it to get rid of it: >> >> https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.19&id=fcde59feb1affb6d56aecadc3868df4631480da5 > > If you are rebasing it, please add the following tag so that the bug > is closed later: > > Tested-by: syzbot+b6c9b65b6753d333d833@syzkaller.appspotmail.com Sorry, missed that, would be a bit confusing? 5.20 branch is rebased on top of that too. Can we just do: #syz fix: io_uring: add io_op_defs 'def' pointer in req init and issue ? -- Jens Axboe