From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A07E9C433DB for ; Wed, 10 Feb 2021 20:31:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BE1564EE5 for ; Wed, 10 Feb 2021 20:31:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232596AbhBJUbG (ORCPT ); Wed, 10 Feb 2021 15:31:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232149AbhBJUbF (ORCPT ); Wed, 10 Feb 2021 15:31:05 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28425C061574 for ; Wed, 10 Feb 2021 12:30:25 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id t11so1984038pgu.8 for ; Wed, 10 Feb 2021 12:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PJmyrPMtY2yl3dmSpn8becwEl0NxjN1C6ENVTeSAzlE=; b=X7XpCWjvk18kXKw4kgMeu1XUk8U7GbMdhpE5e+l1++YScKxVkxab8MNbcLqNr8wBrr ZJZ818OauFIFOg8P7lTA8QQ4ETqmSmWEKzpn0fV3uJFPPt1PO/737jzcipfov7sQK3m0 SXXOqLOEV46SOP162eAoPlNnq2fEEZr6ePUJuZ3ggRxeuC08BXeJ61psj8R6jcDJqUYy +gvEM6tGLocvi2BGtrERzlFYVIAg984r9+5DSJ6uNo1EueaGvzaLwwLhFNU6G60pKHOp ie4f7uaIrDinfLIjYZLqb51AVW716iBugIMb+XLb/au/6HDLHquWlyrkTfRDhmb4tCMk AEBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PJmyrPMtY2yl3dmSpn8becwEl0NxjN1C6ENVTeSAzlE=; b=lCaZYgF/QSDw0GJ6HU0kqv/SyzO1pQkldn6GBowDulVjQ7civN428ReJQAPB35nLfJ WEg8YTDpm/PQz/jotAYnBenw8ZnLi6vcdCL9DQ2lbhwuehyDP8iXTp1kZ9krsYm4AnhC 6ydJHGa3JO4vBtdjzctl+gHHGy0dcwOiUd//5YvdAOqUxVAeragEDIE3SJu8Ed7RxiIm IBSH/FoFcTKP5S/6UKtul9KxIaeJWqM6d72XS0OWD1W4bCIauHIn/khfNXlS7Qr4l7C8 AmnJ5Ag6K06nyPqSSOTb7hH8SjIzsbaBEshEJxKks750WvSmiOAOpp3HjpGwR/VN1FKp MKPg== X-Gm-Message-State: AOAM533wEJPvbai+RqjSfK/kdMokSPPQ64TAHXbe6C7q9fquDRgahYAS SviWBctgYoMbmEiYxhjfMrlT/w== X-Google-Smtp-Source: ABdhPJx/uZo8a0fja85mAj0hfq+nTFT8A2F/S0ELEgZ/8HdLoCv/0e1g8z3yendy4HZ4EAakwBh3rA== X-Received: by 2002:a63:e54f:: with SMTP id z15mr4664275pgj.247.1612989024640; Wed, 10 Feb 2021 12:30:24 -0800 (PST) Received: from ?IPv6:2620:10d:c085:21c1::194c? ([2620:10d:c090:400::5:a5c1]) by smtp.gmail.com with ESMTPSA id it6sm2915538pjb.15.2021.02.10.12.30.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Feb 2021 12:30:24 -0800 (PST) Subject: Re: [PATCH][next] io_uring: remove redundant initialization of variable ret To: Colin King , Pavel Begunkov , io-uring@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210210200007.149248-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <7cbce70d-741e-2948-d1c4-9f30a89d029d@kernel.dk> Date: Wed, 10 Feb 2021 13:30:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210210200007.149248-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/10/21 1:00 PM, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Applied, thanks. -- Jens Axboe