From: Pavel Begunkov <asml.silence@gmail.com>
To: Anuj Gupta <anuj20.g@samsung.com>,
io-uring@vger.kernel.org, anuj1072538@gmail.com, axboe@kernel.dk
Cc: joshi.k@samsung.com
Subject: Re: [PATCH liburing] test/io_uring_passthrough: add test for vectored fixed-buffers
Date: Wed, 21 May 2025 10:42:03 +0100 [thread overview]
Message-ID: <7e846c8a-3506-4581-bbc5-fdf9e084a5bf@gmail.com> (raw)
In-Reply-To: <20250521081949.10497-1-anuj20.g@samsung.com>
On 5/21/25 09:19, Anuj Gupta wrote:
> This patch adds support for vectored fixed buffer I/O using io_uring
> nvme passthrough, enabling broader testing of this path. Since older
> kernels may return -EINVAL for this combination (fixed + vectored), the
> test now detects this failure at runtime via a vec_fixed_supported flag.
> Subsequent iterations skip only the unsupported combinations while
> continuing to test all other valid variants.
LGTM, it's great to have the test, thanks Anuj. FWIW, that's the
same way I tested the kernel patch.
Somewhat unrelated questions, is there some particular reason why all
vectored versions are limited to 1 entry iovec? And why do we even care
calling io_uring_prep_read/write*() helpers when non of the rw related
fields set are used by passthrough? i.e. iovec passed in the second half
of the sqe.
--
Pavel Begunkov
next prev parent reply other threads:[~2025-05-21 9:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250521083658epcas5p2c2d23dbcfac4242343365bb85301c5ea@epcas5p2.samsung.com>
2025-05-21 8:19 ` [PATCH liburing] test/io_uring_passthrough: add test for vectored fixed-buffers Anuj Gupta
2025-05-21 9:42 ` Pavel Begunkov [this message]
2025-05-21 10:35 ` Anuj gupta
2025-05-21 13:08 ` Jens Axboe
2025-05-21 14:20 ` Anuj gupta
2025-05-21 14:24 ` Jens Axboe
2025-05-21 14:05 ` Pavel Begunkov
2025-05-21 14:14 ` Jens Axboe
2025-05-21 14:46 ` Pavel Begunkov
2025-05-21 14:51 ` Jens Axboe
2025-05-21 13:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e846c8a-3506-4581-bbc5-fdf9e084a5bf@gmail.com \
--to=asml.silence@gmail.com \
--cc=anuj1072538@gmail.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox