public inbox for [email protected]
 help / color / mirror / Atom feed
* Re: [PATCH liburing v3 0/2] add support for new timeout feature
@ 2020-08-05  3:28 Carter Li 李通洲
  2020-08-05  5:17 ` Jiufei Xue
  0 siblings, 1 reply; 4+ messages in thread
From: Carter Li 李通洲 @ 2020-08-05  3:28 UTC (permalink / raw)
  To: Jiufei Xue; +Cc: io-uring

> diff --git a/src/include/liburing.h b/src/include/liburing.h
> index 0505a4f..82c2980 100644
> --- a/src/include/liburing.h
> +++ b/src/include/liburing.h
> @@ -56,6 +56,9 @@ struct io_uring {
>  	struct io_uring_sq sq;
>  	struct io_uring_cq cq;
>  	unsigned flags;
> +	unsigned flags_internal;
> +	unsigned features;
> +	unsigned pad[4];
>  	int ring_fd;
>  };

Won't it break existing code runs on newer kernel?
Won't it break code compiled with new liburing but runs on older kernel?

IMO In this case, a new syscall `io_uring_setup2` is required at least.

Regards,
Carter


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH liburing v3 0/2] add support for new timeout feature
@ 2020-08-05  3:04 Jiufei Xue
  0 siblings, 0 replies; 4+ messages in thread
From: Jiufei Xue @ 2020-08-05  3:04 UTC (permalink / raw)
  To: axboe; +Cc: io-uring, metze

Kernel can handle timeout when feature IORING_FEAT_GETEVENTS_TIMEOUT
supported. Applications should use io_uring_set_cqwait_timeout()
explicitly to asked for the new feature.

Changes since v2:
- bump the version to 2.0.7 since we have changed the size of io_uring
- add more pad to structure io_uring for future flexibility

Jiufei Xue (2):
io_uring_enter: add timeout support
test/timeout: add testcase for new timeout feature

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-05  6:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-05  3:28 [PATCH liburing v3 0/2] add support for new timeout feature Carter Li 李通洲
2020-08-05  5:17 ` Jiufei Xue
2020-08-05  6:18   ` Carter Li 李通洲
  -- strict thread matches above, loose matches on Subject: below --
2020-08-05  3:04 Jiufei Xue

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox