From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E75C43334 for ; Mon, 25 Jul 2022 12:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbiGYMfo (ORCPT ); Mon, 25 Jul 2022 08:35:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232450AbiGYMfm (ORCPT ); Mon, 25 Jul 2022 08:35:42 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B01FDEFD for ; Mon, 25 Jul 2022 05:35:41 -0700 (PDT) Received: from [192.168.88.254] (unknown [125.160.106.238]) by gnuweeb.org (Postfix) with ESMTPSA id 1FB047E257; Mon, 25 Jul 2022 12:35:39 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1658752541; bh=bu5GJXcXdXRLDXkXTNfT79BaAAA3a8RLcvV1AlCRxf0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bGhurSgjMvBCzrDYtrKzQi4eUAOI3TcMdsd9LM/okIFzwdZS78jQ8Hs74YBkDeg1P YCKxN3oJJlThZUdJilQ9Aeci2gPGH9VOBtT94F8ezV2gLZdMYZD/eRWCp1Lrso/EBX VXe7euLsEK3pg0mKUzByJnVv7yqFU2pFHGvnki9zgTDAHv8WQpSGFBIRQ5sUeOqrBN c/sTWkIUljQhKRa16QTZBkVS2tvOKoyG+6EpKFjT5+9voYhxr4vttLa18y1xXfDILS jMZxWMHx1QFKTIyL0qSyZToT1u2O240lcw1mfOl618j91CAT39W2gkr3LoXM0r7o3J MoP9ToYOM1Grw== Message-ID: <7efb353d-46ab-47ce-e85e-43ccfb6c8fc0@gnuweeb.org> Date: Mon, 25 Jul 2022 19:35:37 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH liburing v2 2/5] liburing: add zc send and notif helpers Content-Language: en-US To: Pavel Begunkov , io-uring@vger.kernel.org Cc: Jens Axboe References: From: Ammar Faizi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 7/25/22 6:33 PM, Pavel Begunkov wrote: > Add helpers for notification registration and preparing zerocopy send > requests. > > Signed-off-by: Pavel Begunkov > --- > src/include/liburing.h | 42 ++++++++++++++++++++++++++++++++++++++++++ > src/liburing.map | 2 ++ > src/register.c | 20 ++++++++++++++++++++ > 3 files changed, 64 insertions(+) [...] > +static inline void io_uring_prep_notif_update(struct io_uring_sqe *sqe, > + __u64 new_tag, /* 0 to ignore */ > + unsigned offset, unsigned nr) > +{ > + io_uring_prep_rw(IORING_OP_FILES_UPDATE, sqe, -1, 0, nr, > + (__u64)offset); > + sqe->addr = new_tag; > + sqe->ioprio = IORING_RSRC_UPDATE_NOTIF; > +} The same nit on there. But overall it looks good. Reviewed-by: Ammar Faizi -- Ammar Faizi