From: Jens Axboe <[email protected]>
To: Ammar Faizi <[email protected]>, Dylan Yudaken <[email protected]>
Cc: io-uring Mailing List <[email protected]>,
Pavel Begunkov <[email protected]>
Subject: Re: [PATCH liburing v4] test that unregister_files processes task work
Date: Tue, 8 Nov 2022 07:11:34 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 11/8/22 5:50 AM, Ammar Faizi wrote:
> On 11/8/22 7:42 PM, Dylan Yudaken wrote:
>> Ensure that unregister_files processes task work from defer_taskrun even
>> when not explicitly flushed.
>>
>> Signed-off-by: Dylan Yudaken <[email protected]>
>
> I feel a bit irritated because the close() and io_uring_queue_exit()
> don't get invoked in the error paths. But not a big deal, since in the
> test we'll be exiting soon after that :p
Yeah, lots of tests to that - in case of error, just return the error
and the test will exit anyway. Obviously not kosher for a real
application, but I view it like leaking heap data in that regard. It'll
get reaped when the application goes away, and is again not something
you'd do in a real application.
--
Jens Axboe
next prev parent reply other threads:[~2022-11-08 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 12:42 [PATCH liburing v4] test that unregister_files processes task work Dylan Yudaken
2022-11-08 12:50 ` Ammar Faizi
2022-11-08 14:11 ` Jens Axboe [this message]
2022-11-08 14:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox