From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE769C6FD1D for ; Tue, 14 Mar 2023 12:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231685AbjCNMFg (ORCPT ); Tue, 14 Mar 2023 08:05:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231599AbjCNMF3 (ORCPT ); Tue, 14 Mar 2023 08:05:29 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38B5313514 for ; Tue, 14 Mar 2023 05:04:59 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id n16so3986405pfu.11 for ; Tue, 14 Mar 2023 05:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; t=1678795474; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VPBOK1C4IbcoM0/ywvEaqwF73HOJT79t3iQlchMtOYs=; b=lOOlEyQCKMgOg6NHsAgdUmeFXQn8soeOeW7+ib8AUJby6J9R64gAm/S+N7rQh96hm2 dK39dfxuYSCgoTbIbqJYUMh3uEmoTbQLdlhXxW7FQDPgGJckV45pJz6rNEi7094AhS22 w+Peow/VSWOsG1SWk3xnH+B7XQKXs6fxDq0TJwaMyQtqfRc6eMeYdhD1VnMvpfSRXx9H l04+FGVmivZfrXBtYK2GWQuMULJG2xOjxClpPgU2RZuSKZNRgmMyohEtaq7N3awbnfjo UNpSQ4vH8vupGW9vI+wgKqd6VuFYsIs5+E2E/6tFnq/yWZFD5IyIxeM1Gze5do74BuKZ AM+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678795474; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VPBOK1C4IbcoM0/ywvEaqwF73HOJT79t3iQlchMtOYs=; b=djIbb1j5sGcpF7qgA5aFZ1QMbe9LFF24m/faxEP4n5pBYy7arWugn9DCVA2zxh8n9e WmpDYTWXmo2lPQpJ/INk0APpBqMeAiqZoIwdVEJne4MJ/HVOhsgJ/vEbgw4TTwpS+GYf 7kgxTzzIqelzOBeODWRgmuyy6sDu+TYbX+tNXaqkYelhGItvu5m+y3w5wrgc9dzm7Gi/ WTMwWeFI8tpw0rL+isWkWUFPCGBeCzC+EQbGlnb5rcpUZdkMIvcUNnV9rA6j1fZ9gILo nVH41aSaLuM/X8wvMA9+Izcm1YqxaOv60+7I6yJ4GQ9WiqIsA1fM9/6eESlVc+de9HvZ i+zg== X-Gm-Message-State: AO0yUKV317JImaO7unZSMGNkKhDUN+I8l19tGtu2Uu5EajzeXkX+tN4I NJOMmrCBVA9mBvZHX8wD5KuPJS2H05fZPa3p5LxoZg== X-Google-Smtp-Source: AK7set8APD7WqHOJnbrWMLgna6F234oYpxPZK26LvWhX7pAYo1Bzg/RD0SX86qcYYY8uE/w/czk9lA== X-Received: by 2002:aa7:8591:0:b0:625:6439:657a with SMTP id w17-20020aa78591000000b006256439657amr1798035pfn.0.1678795473566; Tue, 14 Mar 2023 05:04:33 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id a16-20020aa780d0000000b005a9ea5d43ddsm1482273pfn.174.2023.03.14.05.04.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 05:04:33 -0700 (PDT) Message-ID: <7f5666c8-6950-57aa-5be4-1ecb78168130@kernel.dk> Date: Tue, 14 Mar 2023 06:04:32 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/3] pipe: enable handling of IOCB_NOWAIT Content-Language: en-US To: Matthew Wilcox Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20230308031033.155717-1-axboe@kernel.dk> <20230308031033.155717-3-axboe@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 3/14/23 3:38?AM, Matthew Wilcox wrote: > On Tue, Mar 07, 2023 at 08:10:32PM -0700, Jens Axboe wrote: >> @@ -493,9 +507,13 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from) >> int copied; >> >> if (!page) { >> - page = alloc_page(GFP_HIGHUSER | __GFP_ACCOUNT); >> + gfp_t gfp = __GFP_HIGHMEM | __GFP_ACCOUNT; >> + >> + if (!nonblock) >> + gfp |= GFP_USER; >> + page = alloc_page(gfp); > > Hmm, looks like you drop __GFP_HARDWALL in the nonblock case. People who > use cpusets might be annoyed by that. Ah good catch! Yes, that's an oversight, I'll rectify that in v2. >> if (unlikely(!page)) { >> - ret = ret ? : -ENOMEM; >> + ret = ret ? : nonblock ? -EAGAIN : -ENOMEM; > > double ternary operator? really? yeah sorry... See reply to Christian, I'll make this cleaner. -- Jens Axboe