From: Jens Axboe <[email protected]>
To: Oleg Nesterov <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH 1/4] task_work: add task_work_pending() helper
Date: Tue, 7 Apr 2020 08:43:44 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/7/20 4:28 AM, Oleg Nesterov wrote:
> On 04/06, Jens Axboe wrote:
>>
>> +static inline bool task_work_pending(void)
>> +{
>> + return current->task_works;
>> +}
>> +
>> +static inline void task_work_run(void)
>> +{
>> + if (task_work_pending())
>> + __task_work_run();
>> +}
>
> No, this is wrong. exit_task_work() must always call __task_work_run()
> to install work_exited.
>
> This helper (and 3/4) probably makes sense but please change exit_task_work()
> to use __task_work_run() then.
Good catch, thanks. I'll make the change.
--
Jens Axboe
next prev parent reply other threads:[~2020-04-07 15:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 19:48 [PATCHSET 0/4] io_uring and task_work interactions Jens Axboe
2020-04-06 19:48 ` [PATCH 1/4] task_work: add task_work_pending() helper Jens Axboe
2020-04-07 11:28 ` Oleg Nesterov
2020-04-07 15:43 ` Jens Axboe [this message]
2020-04-06 19:48 ` [PATCH 2/4] task_work: don't run task_work if task_work_exited is queued Jens Axboe
2020-04-07 11:39 ` Oleg Nesterov
2020-04-07 11:54 ` Oleg Nesterov
2020-04-07 15:40 ` Jens Axboe
2020-04-07 16:19 ` Oleg Nesterov
2020-04-07 16:59 ` Jens Axboe
2020-04-07 17:43 ` Oleg Nesterov
2020-04-07 12:47 ` Peter Zijlstra
2020-04-07 15:43 ` Jens Axboe
2020-04-06 19:48 ` [PATCH 3/4] task_work: kill current->task_works checking in callers Jens Axboe
2020-04-06 19:48 ` [PATCH 4/4] io_uring: flush task work before waiting for ring exit Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-04-07 16:02 [PATCHSET v2] io_uring and task_work interactions Jens Axboe
2020-04-07 16:02 ` [PATCH 1/4] task_work: add task_work_pending() helper Jens Axboe
2020-04-07 17:52 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox