From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring/register: use correct location for io_rings_layout
Date: Wed, 19 Nov 2025 17:18:16 +0000 [thread overview]
Message-ID: <7febd726-8744-4d3a-a282-86215d34892f@gmail.com> (raw)
In-Reply-To: <64459921-de76-4e5c-8f2b-52e63461d3d4@kernel.dk>
On 11/19/25 02:36, Jens Axboe wrote:
> A previous consolidated the ring size etc calculations into
> io_prepare_config(), but missed updating io_register_resize_rings()
> correctly to use the calculated values. As a result, it ended up using
> on-stack uninitialized values, and hence either failed validating the
> size correctly, or just failed resizing because the sizes were random.
>
> This caused failures in the liburing regression tests:
That made me wonder how it could possibly pass tests for me. I even
made sure it was reaching the final return. Turns out the layout was
0 initialised, region creation fails with -EINVAL, and then the
resizing test just silently skips sub-cases. It'd be great to have
a "not supported, skip" message.
--
Pavel Begunkov
next prev parent reply other threads:[~2025-11-19 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 2:36 [PATCH] io_uring/register: use correct location for io_rings_layout Jens Axboe
2025-11-19 17:18 ` Pavel Begunkov [this message]
2025-11-19 20:22 ` Jens Axboe
2025-11-21 13:49 ` Pavel Begunkov
2025-11-21 13:59 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7febd726-8744-4d3a-a282-86215d34892f@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox