From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EAEDC433E2 for ; Wed, 9 Sep 2020 07:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CBE721D79 for ; Wed, 9 Sep 2020 07:11:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MwdpsPig" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725975AbgIIHL5 (ORCPT ); Wed, 9 Sep 2020 03:11:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbgIIHLz (ORCPT ); Wed, 9 Sep 2020 03:11:55 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48D43C061573 for ; Wed, 9 Sep 2020 00:11:55 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id z22so1998297ejl.7 for ; Wed, 09 Sep 2020 00:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iYPk04Ba5kJwk9651p7tIZd7TTGFYI1Sbmgq3t1BJxs=; b=MwdpsPigMo531Too0UorIGjfRZK+DFz6jl49wkAQ51UticJCHGTFCnbvTfrp1leCBp n5FnuzQ5+ak33faowhgE+gVH1TUWF9skpcwXUmr4st/u0Usfxh2IvV/vSQjBJ6hfLZLc QqjJJA2h+V7s90JYVrmXN5dJmIIMhxNzWefumKeHk7V4yRyWsbO0zBMVU113B5p9DEZH evw5BRTM9+xtzgSbFMR/gc7tnqs3V7Qpye4J41fN5kxoP8D1YQj2xX985Y3q6dIauaK6 ZK6YRypfiKXEe9MFR/N7nLYsU3dZoWtZWU2vcg6rjlBy8nCqyMwnLZV+HZaxmNwjNk+U FOhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iYPk04Ba5kJwk9651p7tIZd7TTGFYI1Sbmgq3t1BJxs=; b=TVGUh5dwrl3kuXFZUz1eUyKcljDNg3xkrWhjQRFnOi/JVrtdbVqfgFQfGqHXLyLKaa 1MdszrILOlmIPRdjZI2iEBihp5iDZfV1MOT/FWNtU4T/WiJkP2tYJ1IWi6TvnUm8IGPA /3jA7jzZ41IU4weCPHJTTwpA7CqNSSGtyzDUR7WfzvjJRnGKsS2bLYAHBA3yr9DTn4/x leIrTWWiLFnOAf1auDk+3Ljqox2cHAp2/A2/LEktJBFjU15gB7OerDOfV7VHI0Aa+BF1 LvVcKM/Eu2gxguqFcxJAR6IOG59VcVS17CPJfLbAwVxPPH/eXghEPoi7WND7xcLoZ/5k zfIw== X-Gm-Message-State: AOAM532pNeh5s9e89qjlnosiVAh+rsLiEjbcEjJWUYLIQyEgsbQ01G5b bU2nvmpuxX3hl6p5tcHMBtEWMTTKlbc= X-Google-Smtp-Source: ABdhPJygHXZl6k4q1vToxfegZ4aj7/RstxWU6UJOrh/8KIYEbMIeHRl0Bb0NgzuxM7D2CkkU0ne+Gg== X-Received: by 2002:a17:906:bc47:: with SMTP id s7mr2417218ejv.354.1599635513762; Wed, 09 Sep 2020 00:11:53 -0700 (PDT) Received: from [192.168.43.239] ([5.100.193.184]) by smtp.gmail.com with ESMTPSA id k25sm1184793ejk.3.2020.09.09.00.11.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2020 00:11:53 -0700 (PDT) To: Jens Axboe , io-uring References: <8f6871c4-1344-8556-25a7-5c875aebe4a5@gmail.com> <622649c5-e30d-bc3c-4709-bbe60729cca1@kernel.dk> <1c088b17-53bb-0d6d-6573-a1958db88426@kernel.dk> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: [PATCH for-next] io_uring: ensure IOSQE_ASYNC file table grabbing works, with SQPOLL Message-ID: <801ed334-54ea-bdee-4d81-34b7e358b506@gmail.com> Date: Wed, 9 Sep 2020 10:09:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1c088b17-53bb-0d6d-6573-a1958db88426@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 09/09/2020 01:54, Jens Axboe wrote: > On 9/8/20 3:22 PM, Jens Axboe wrote: >> On 9/8/20 2:58 PM, Pavel Begunkov wrote: >>> On 08/09/2020 20:48, Jens Axboe wrote: >>>> Fd instantiating commands like IORING_OP_ACCEPT now work with SQPOLL, but >>>> we have an error in grabbing that if IOSQE_ASYNC is set. Ensure we assign >>>> the ring fd/file appropriately so we can defer grab them. >>> >>> IIRC, for fcheck() in io_grab_files() to work it should be under fdget(), >>> that isn't the case with SQPOLL threads. Am I mistaken? >>> >>> And it looks strange that the following snippet will effectively disable >>> such requests. >>> >>> fd = dup(ring_fd) >>> close(ring_fd) >>> ring_fd = fd >> >> Not disagreeing with that, I think my initial posting made it clear >> it was a hack. Just piled it in there for easier testing in terms >> of functionality. >> >> But the next question is how to do this right...> > Looking at this a bit more, and I don't necessarily think there's a > better option. If you dup+close, then it just won't work. We have no > way of knowing if the 'fd' changed, but we can detect if it was closed > and then we'll end up just EBADF'ing the requests. > > So right now the answer is that we can support this just fine with > SQPOLL, but you better not dup and close the original fd. Which is not > ideal, but better than NOT being able to support it. > > Only other option I see is to to provide an io_uring_register() > command to update the fd/file associated with it. Which may be useful, > it allows a process to indeed to this, if it absolutely has to. Let's put aside such dirty hacks, at least until someone actually needs it. Ideally, for many reasons I'd prefer to get rid of fcheck(ctx->ring_fd) in favour of synchronisation in io_grab_files(), but I wish I knew how. -- Pavel Begunkov